Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CI / CD to GitHub Actions #1068

Open
4 of 16 tasks
defagos opened this issue Nov 19, 2024 · 2 comments · May be fixed by #1075
Open
4 of 16 tasks

Migrate CI / CD to GitHub Actions #1068

defagos opened this issue Nov 19, 2024 · 2 comments · May be fixed by #1075
Assignees
Labels
tooling Issues related to the tools we use

Comments

@defagos
Copy link
Member

defagos commented Nov 19, 2024

As a Pillarbox developer I want a reliable CI orchestrated using GitHub Actions.

Acceptance criteria

  • All existing CI tasks can be run through GitHub Actions on self-hosted hardware.
  • Tasks perform in reasonable time.

Tasks

  • Update scripts to be run with pkgx.
  • Create dedicated workflows.
  • Replace private configuration repository with GitHub secrets (p12 certificate and associated password, p8, other info).
  • Make repository structure simpler (e.g. no more need for symlinks to .env).
  • Create workflow for nightly / release demo builds.
  • Ensure steps fail correctly (e.g. if one test fails the test step must fail). See this example.
  • Update repository configuration.
  • Integrate with GitHub deployments.
  • Only keep make targets that can be run locally.
  • Update developer documentation (in particular the required tool list after migration).
  • Optimize test suite (identify tests that take too long or reach the timeout, tweak timeouts, etc.).
  • Document CI setup, replacing the old Team City documentation (e.g. secrets and envvars to setup).
  • Archive or delete existing configurations on Team City.
  • Archive private configuration repository (update Fastfile accordingly).
  • Archive GitHub Actions PoC repositories (keep them for future reference if needed).
  • Inform other teams we have left the TeamCity CI.
@defagos defagos converted this from a draft issue Nov 19, 2024
@defagos defagos added the tooling Issues related to the tools we use label Nov 19, 2024
@defagos defagos moved this from 📋 Backlog to 🚧 In Progress in Pillarbox Nov 27, 2024
@defagos
Copy link
Member Author

defagos commented Nov 28, 2024

For the moment we decided not to fix any macOS / tool version and to always use the latest versions available. Best practices would probably recommend to fix versions but we'll see if this is really an issue and adjust accordingly (it never really was with our old CI pipeline).

@waliid waliid linked a pull request Nov 28, 2024 that will close this issue
4 tasks
@defagos
Copy link
Member Author

defagos commented Nov 28, 2024

We discussed about updating our scripts to ZSH (now the default on macOS) but this will be delayed until shellcheck supports it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Issues related to the tools we use
Projects
Status: 🚧 In Progress
Development

Successfully merging a pull request may close this issue.

2 participants