Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lost commit history? #2

Open
tunnell opened this issue Dec 14, 2020 · 9 comments
Open

Lost commit history? #2

tunnell opened this issue Dec 14, 2020 · 9 comments

Comments

@tunnell
Copy link

tunnell commented Dec 14, 2020

This package seems like a copy-paste of the package here, which means that we lost the commit history and can't see how previous development (or issue tracker) was done. Can we either fork the other repository, or I can transfer ownership here if that is preferred?

@tunnell
Copy link
Author

tunnell commented Dec 31, 2020

@myNameIsPatrick

@myNameIsPatrick
Copy link
Collaborator

Hi @tunnell, apologies for the late reply. The packages certainly look similar and that is mostly intentional. Both the snews plugin and the app repos were created using cookiecutter templates (https://github.com/scimma/hop-plugin-template, https://github.com/scimma/hop-app-template). The plugin template was developed to aid in creating a repo for plugins and was motivated by the SNEWS work, and a snapshot of the plugin codebase was migrated to this repo in this commit (SNEWS2/hop-SNalert-app@2d56413). It did unfortunately make it more difficult to track the commit history before this point in this repo (it is still captured in the original repo, however).

@bfc5288
Copy link

bfc5288 commented Jan 5, 2021

@tunnell To clarify a few points, this hop-plugin-snews package is similar but separate from the snews app itself (which is still in the RiceAstroparticleLab repo).

This hop-plugin-snews code doesn't provide the core SNEWS functionality (message storage, deciding, alerting, etc.) -- all of that functionality is still in the original RiceAstroparticleLab repo). This repo just provides the message formats that're used by that app (though as @myNameIsPatrick mentioned, the codebases have the same skeleton based on SCiMMA's cookiecutter templates).

This means that the core app (and development history) are still all contained in the original repository (and so a Zenodo reference could reasonably point there). Though it may be possible to consolidate the core code with the plugin within the SNEWS organization, if there's interest.

@tunnell
Copy link
Author

tunnell commented Jan 5, 2021

Yeah, it might make sense to consolidate. Thanks for explaining. At very least, @yiyangxu1998 can you move the Rice repository here?

@skylerxu1998
Copy link
Collaborator

Yes give me a little time. I'll get back shortly.

@skylerxu1998
Copy link
Collaborator

@tunnell @bfc5288 We would want to transfer the repo right?

@bfc5288
Copy link

bfc5288 commented Jan 6, 2021

@tunnell @bfc5288 We would want to transfer the repo right?

Yes, I would say so. It looks like there is a safe method to do this without losing the history of commits, pull requests, issues, etc. based on the Github docs.

@skylerxu1998
Copy link
Collaborator

Yeah just wanted to make sure tranferring is the way we want. Thanks

@skylerxu1998
Copy link
Collaborator

@tunnell The repo is linked to Zenodo, but I cannot create a release after trasferring the repo. I think it might need permission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants