Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Each observation message should create a heartbeat #114

Open
KaraMelih opened this issue Aug 13, 2024 · 4 comments
Open

Each observation message should create a heartbeat #114

KaraMelih opened this issue Aug 13, 2024 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@KaraMelih
Copy link
Collaborator

Especially when testing, we do not send periodic heartbeats. So what happens is, we trigger an alert but the server thinks that there are no available detectors, and thus the false-alarm computation function struggles (well, it crashes; see SNEWS2/SNEWS_Coincidence_System#100)

We should be attaching a heartbeat each time we receive a coincidence message.

@KaraMelih KaraMelih added enhancement New feature or request help wanted Extra attention is needed labels Aug 13, 2024
@habig
Copy link
Contributor

habig commented Aug 14, 2024

One side effect I can see happening from this is that when a signal goes in, the heartbeat rate might jump up and cross the notification threshold.

Which isn't a problem, the contact will get an email, but that contact is either testing and knows it, or would appreciate an extra email from SNEWS since his experiment is probably screaming "SUPERNOVA" and knowing the signal went in is a nice side effect.

@KaraMelih
Copy link
Collaborator Author

hmm. I think the heartbeat warnings are sent only if the heartbeat is not received within mu+3sigma but I don't think anything happens if there is an early heartbeat within mu-3sigma.

@KaraMelih
Copy link
Collaborator Author

Being implemented in this PR #116

@habig
Copy link
Contributor

habig commented Aug 14, 2024

Ahh ok! So no worries then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants