Feat: 개인정보 및 약관 동의 페이지 디자인 수정 #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….com/SMWU-POCHAK/POCHAK-iOS into feat/102-policyAgreementPageReDesign
yoogail105
reviewed
Dec 2, 2024
Comment on lines
+189
to
+198
| private func setupPochakLogoImageView() { | ||
| view.addSubview(pochakLetterLogoImageView) | ||
|
|
||
| pochakLetterLogoImageView.translatesAutoresizingMaskIntoConstraints = false | ||
|
|
||
| NSLayoutConstraint.activate([ | ||
| pochakLetterLogoImageView.topAnchor.constraint(equalTo: view.safeAreaLayoutGuide.topAnchor, constant: 44), | ||
| pochakLetterLogoImageView.leadingAnchor.constraint(equalTo: view.safeAreaLayoutGuide.leadingAnchor, constant: 20), | ||
| ]) | ||
| } |
There was a problem hiding this comment.
뷰마다 함수로 나눈 것은 좋은 시도 같아요!
하지만 레이아웃 관련된 코드를 한 곳에 모아두는 것이 코드 상에서 뷰의 구조를 한 번에 파악하기에 더 좋을 것 같다는 생각이 듭니다!
ex.
private func addSubViews() {
view.addSubview(pochakLetterLogoImageView)
view.addSubview(guideLabel)
//...
}
private func setfupLayout() {
NSLayoutConstraint.activate([
pochakLetterLogoImageView.topAnchor.constraint(equalTo: view.safeAreaLayoutGuide.topAnchor, constant: 44),
pochakLetterLogoImageView.leadingAnchor.constraint(equalTo: view.safeAreaLayoutGuide.leadingAnchor, constant: 20),
])
NSLayoutConstraint.activate([
guideLabel.leadingAnchor.constraint(equalTo: pochakLetterLogoImageView.leadingAnchor),
guideLabel.topAnchor.constraint(equalTo: pochakLetterLogoImageView.bottomAnchor, constant: 8),
])
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💌 작업한 내용
💭 PR POINT
📷 스크린샷
💐 관련 이슈