Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mode problems #90

Open
ue71603 opened this issue Apr 11, 2022 · 4 comments
Open

Mode problems #90

ue71603 opened this issue Apr 11, 2022 · 4 comments
Assignees

Comments

@ue71603
Copy link
Collaborator

ue71603 commented Apr 11, 2022

Mode seems to be very unorganised within Siri:
We have:

  • Mode based on AllModesEnumeration in siri_model/siri-reference.xsd which is clearly falsly defined
  • ContinuosModesEnumeration in siri_model/siri_reference.xsd
  • VehicleModesEnumeration in siri_model/siri_reference.xsd
  • Mode based on AffectedModeGroup which references VehicleMode, PtNetworkModeChoiceGoup and AccessMode basedn on ifopt:AccessModesEnumeration
  • VehicleMode (siri_modes.xsd) is based on VehicleModesOfTransportEnumeration and contains a lot "blablablaService"
  • In siri_modes we have also ModeChoiceGroup and PtModeChoiceGroup
  • AccessModesEnumeration is then again different fromn ContinuosModesEnumeration in ifopt/ifopt_modes.xsd

This needs to be simplified, it needs to be aligned with NeTEx. the blablaService needs to be dropped.

@Aurige
Copy link
Contributor

Aurige commented Apr 11, 2022

Yes I agree... this is mainly due to the fact that SIRI started before NeTEx, tried to integrate values from TPEG and DATEX to ease compatibility, and the latest revision was finalised before NeTEx Part 5.
Also the way to clean it has to be discussed with the group since some decisions may raise backward compatibility issues.

@ue71603
Copy link
Collaborator Author

ue71603 commented Apr 12, 2022

That's why it si an issue and not a pull request ;-). Do you bring it up at the next meeting? Or @haeckerbaer

@Aurige
Copy link
Contributor

Aurige commented Apr 12, 2022

it can be mentioned but I'm afraid that we will need to wait for next revision

@ue71603
Copy link
Collaborator Author

ue71603 commented Mar 20, 2024

In general MODE and MODE OF OPERATIOn from Transmodel should be taken into account now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants