Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active Initial test model? #38

Open
tonyvsuk opened this issue Sep 8, 2017 · 4 comments
Open

Active Initial test model? #38

tonyvsuk opened this issue Sep 8, 2017 · 4 comments

Comments

@tonyvsuk
Copy link

tonyvsuk commented Sep 8, 2017

I'm in the process of running the test models through Vensim, but hit a problem.

I'm referring to
https://github.com/SDXorg/test-models/tree/master/tests/active_initial

The development version of Vensim reads the XMILE version fine, but the results are different from the Vensim format model. I cannot see in the XMILE version where the call to active initial is actually made.

Am I misreading things?

Tony.

PS, if this is not the correct place to ask questions, feel free to point me in the right direction.

@JamesPHoughton
Copy link
Contributor

Hey Tony,

I think your reading is correct, that the vensim->xmile translator that generated this model isn't correct. I would expect to see the active initial here.
@wasbridge - do you have a list of which of the tests pass the whole mdl->xmile->stella->timeseries output pathway?

James

@wasbridge
Copy link
Contributor

wasbridge commented Sep 8, 2017

I would expect to see an <init_eqn> tag containing the value 45.

Here is an example generated directly by Stella

<aux name="X"> <eqn>TIME + RANDOM(0, TIME, 1234)</eqn> <init_eqn>77</init_eqn> </aux>

@tonyvsuk
Copy link
Author

tonyvsuk commented Sep 8, 2017

I cannot see <init_eqn> in the XMILE spec. I can probably implement it though, but where does it fit into the XML tree? You can already of multiple equations for various elements, so how do you tie <init_eqn> to the correct tag?

@wasbridge
Copy link
Contributor

wasbridge commented Sep 8, 2017

It always goes next to the <eqn> tag (at least how we've implemented it).

Here are all of the examples (scalar, A2A (apply to all) and Non A2A)

<aux name="X"> <eqn>TIME + RANDOM(0, TIME, 1234)</eqn> <init_eqn>77</init_eqn> </aux> <aux name="A2A array"> <dimensions> <dim name="Dimension"/> </dimensions> <eqn>RANDOM(0, TIME, 1234)</eqn> <init_eqn>66</init_eqn> </aux> <aux name="Non A2A array"> <dimensions> <dim name="Dimension"/> </dimensions> <element subscript="1"> <eqn>RANDOM(0, TIME, 1234)</eqn> <init_eqn>1</init_eqn> </element> <element subscript="2"> <eqn>RANDOM(0, TIME, 1234)</eqn> <init_eqn>2</init_eqn> </element> <element subscript="3"> <eqn>RANDOM(0, TIME, 1234)</eqn> <init_eqn>3</init_eqn> </element> <element subscript="4"> <eqn>RANDOM(0, TIME, 1234)</eqn> <init_eqn>4</init_eqn> </element> </aux>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants