Coverity Bugs and Errors

[SAnsell]

Coverity that produce what I think of as an excellent static analysis tool, have scanned the project. That has produced a number of warnings errors. The majority are warnings about constructors not initializing values, however, I am ignoring all those because they are initialized in populate and you can't fail to call populate as it is called in very call to createAll().

Issues that do count:

There is an error with makeCNF -- definitely my fault -- I delete memory and then assume it will be ok. But it is complex and I am going to need a bit of time to figure out a fix. [I need to write some tests first to make sure I don't break things!] I believe it has the possibility to corrupt output.

Then there have been a number of other minor issues that I have been fixing along the way, e.g. incorrect copy constructors. Since much of the code doesn't really rely on them because of the createAll system, I am not sure you will see an impact on output -- but it is better to fix them than not.

Anyway after my first pass I am going to see if I can resubmit and have another go.

If anyone wants to help.....