Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cones -- Not allowed with cut flag #56

Open
SAnsell opened this issue Jan 3, 2017 · 0 comments
Open

Cones -- Not allowed with cut flag #56

SAnsell opened this issue Jan 3, 2017 · 0 comments

Comments

@SAnsell
Copy link
Owner

SAnsell commented Jan 3, 2017

Cones in MCNP can be defined with a cut flag. This chooses the plane that the cone is active on. It is the same as adding a plane at the cone origin and selecting a side. After any rotation that leaves the cone axis out of the XYZ axis of the output model, the code has to be represented as a general quadratic surface. This results in the requirement to add an extra plane.

From now on the use of the cut flag will not be supported in the master branch. [You are welcome to use it in your local models]. I have decided that all such cones in the master model will have the plane added initially and the model adjusted so all rotations are valid.

The main place that needed fixing was in BasicFlightLine.cxx, and further in the derived class for the ESS (WedgeFlightLine.cxx).

Any problems please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant