Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update font weights #746

Closed
3 tasks done
xak opened this issue Oct 12, 2018 · 1 comment
Closed
3 tasks done

Update font weights #746

xak opened this issue Oct 12, 2018 · 1 comment
Assignees
Labels
Milestone

Comments

@xak
Copy link
Contributor

xak commented Oct 12, 2018

The 72 font does not include medium or semi weights so we should not support those values.

The weights in the main map should match those available with the fonts.

Update

$fd-weights: map-merge((
    light: 300,
    normal: 400, //see note below
    bold: 700
), $fd-weights);
  • Update weight mixin to accept only the 3 weights supported.

This should be completed re-written to look up the weight in the map. It does not do that now.

Look up the weight passed to the mixin, if the value is invalid then return normal.

  • Change all references of reg to normal.
    Existing mixins allow for reg to be passed to return the normal or 400 weight. Regular is more of a typographic term and not a CSS term.

Recommend maintaining the reg param for now but docs should be updated to use normal

@mixin fd-weight($weight: normal) {
    @if $weight == reg {
        $weight: normal
    }
    ...
   }
}
@xak xak added the Fiori 3 label Oct 12, 2018
@xak xak added this to the Release 1.3.0 milestone Oct 15, 2018
@xak xak self-assigned this Oct 21, 2018
@xak
Copy link
Contributor Author

xak commented Oct 21, 2018

This is done as part of #741

@saad-mo saad-mo closed this as completed Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants