Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lib] Implement default theme SASS file #735

Closed
xak opened this issue Oct 9, 2018 · 1 comment
Closed

[Lib] Implement default theme SASS file #735

xak opened this issue Oct 9, 2018 · 1 comment

Comments

@xak
Copy link
Contributor

xak commented Oct 9, 2018

Make a theme file that will serve as the settings base

Detailed description

Instead of importing settings into every SASS file, use the theme file which will include the base settings. A default theme can be added in theme dir.

The main change is that each SASS file should now import the following ...

@import "theme";
@import "mixins";
@import "functions";
@xak xak added the Library label Oct 9, 2018
@xak xak added this to the Release 1.3.0 milestone Oct 15, 2018
@xak xak removed this from the v1.3.0 milestone Oct 17, 2018
@xak xak added this to the v1.5.0 milestone Dec 4, 2018
@saad-mo saad-mo changed the title Implement default theme SASS file [Lib] Implement default theme SASS file Jan 2, 2019
@xak
Copy link
Contributor Author

xak commented Jan 29, 2019

This approach is not correct. Closing!

@xak xak closed this as completed Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant