Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shell: Branding #674

Closed
2 tasks
saad-mo opened this issue Sep 12, 2018 · 3 comments
Closed
2 tasks

Shell: Branding #674

saad-mo opened this issue Sep 12, 2018 · 3 comments
Assignees
@eboyer @LeoT7508
Labels
Fiori 3 shell
Milestone
v1.3.0

Comments

@saad-mo
Copy link
Contributor

saad-mo commented Sep 12, 2018

  • Show SAP logo by default
  • show examples of other logos
@saad-mo saad-mo added the shell label Sep 12, 2018
@saad-mo saad-mo added this to the Release 1.3.0 (Shell) milestone Sep 12, 2018
@LeoT7508 LeoT7508 self-assigned this Sep 13, 2018
@LeoT7508
Copy link

@saadmhybris

What is the ask here? Really the logo are should just be a an empty box that can be filled in with any logo.

@saad-mo
Copy link
Contributor Author

saad-mo commented Sep 18, 2018

@LeoT7508 yes. sap logo that would go in the shell header

@saad-mo saad-mo assigned eboyer and unassigned saad-mo Sep 18, 2018
@LeoT7508
Copy link

sap logo
@saadmhybris

@xak xak modified the milestone: Release 1.3.0 Oct 15, 2018
@xak xak added the Fiori 3 label Oct 15, 2018
@eboyer eboyer mentioned this issue Oct 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eboyer eboyer

@LeoT7508 LeoT7508

Labels
Fiori 3 shell
Projects
None yet
Milestone
v1.3.0
Development

No branches or pull requests
4 participants
@eboyer @xak @saad-mo @LeoT7508