Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hybrid-array: Impl Zeroize for Array #984

Merged
merged 5 commits into from
Nov 19, 2023

Conversation

rozbb
Copy link
Contributor

@rozbb rozbb commented Nov 18, 2023

Let me know if you wanna feature gate this.

@rozbb
Copy link
Contributor Author

rozbb commented Nov 18, 2023

I think it might not be possible to make Drop zeroize everything. If you try impl<T: Zeroize, U: ArraySize> Drop for Array<T, U>, it complains that you cannot specialize Drop impls.

hybrid-array/Cargo.toml Outdated Show resolved Hide resolved
@rozbb
Copy link
Contributor Author

rozbb commented Nov 18, 2023

Alright should be good to go

@rozbb
Copy link
Contributor Author

rozbb commented Nov 19, 2023

I believe build is failing because of outdated MSRV elsewhere

hybrid-array/Cargo.toml Outdated Show resolved Hide resolved
tarcieri added a commit that referenced this pull request Nov 19, 2023
This is a simple command line utility intended for internal use only.

There's no need to have an MSRV policy around it, and having one was
breaking the build of #984
tarcieri added a commit that referenced this pull request Nov 19, 2023
This is a simple command line utility intended for internal use only.

There's no need to have an MSRV policy around it, and having one was
breaking the build of #984
tarcieri added a commit that referenced this pull request Nov 19, 2023
This is a simple command line utility intended for internal use only.

There's no need to have an MSRV policy around it, and having one was
breaking the build of #984
@tarcieri
Copy link
Member

#986 removed the MSRV from fiat-constify if you rebase

@tarcieri tarcieri merged commit 3ed8852 into RustCrypto:master Nov 19, 2023
98 checks passed
@rozbb rozbb deleted the hybrid-array-zeroize branch November 19, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants