Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: get_log_xyz_hash #8

Closed
denverbaumgartner opened this issue Nov 22, 2022 · 1 comment
Closed

improvement: get_log_xyz_hash #8

denverbaumgartner opened this issue Nov 22, 2022 · 1 comment

Comments

@denverbaumgartner
Copy link
Contributor

today: throughout the repository almost every contract class has a function called get_log_xyz_hash that returns an event signature. today these values are hardcoded.

soon: it would be great if these values were generated from the contract .sol files upon initialization of the class, or even within rolodex.py
@adamamsmith adamamsmith mentioned this issue May 24, 2023
Merged
@adamamsmith
Copy link
Contributor

Closed by #26

This PR meant these no longer have to be hardcoded however they are still fetched from the abis stored in the repo. However #2 already mentions this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adamamsmith @denverbaumgartner