Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: improved data access without keys #32

Open
denverbaumgartner opened this issue Jun 8, 2023 · 0 comments
Open

enhancement: improved data access without keys #32

denverbaumgartner opened this issue Jun 8, 2023 · 0 comments
Assignees
@denverbaumgartner

Comments

@denverbaumgartner
Copy link
Contributor

when i originally switched the allowance argument to be optional in client.add_pair i did not also make the ERC20 class initialization of the base and quote assets not require a wallet/key. when an allowance is not provided, we should not initialize the ERC20 classes with write permissions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denverbaumgartner denverbaumgartner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@denverbaumgartner