Add model generator tests #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KonstantinLapkovsky
changed the base branch from
master
to
49-cover-entity-generator-with-tests
# Conflicts: # tests/ControllerGeneratorTest.php # tests/NovaResourceGeneratorTest.php # tests/NovaTestGeneratorTest.php # tests/Support/Controller/ControllerMockTrait.php # tests/Support/NovaResource/NovaResourceMockTrait.php # tests/Support/NovaTest/NovaTestMockTrait.php # tests/Support/Shared/GeneratorMockTrait.php # tests/TestCase.php
…erator-tests # Conflicts: # tests/Support/Factory/FactoryMockTrait.php
DenTray
reviewed
Nov 26, 2024
pirs1337
changed the base branch from
49-cover-entity-generator-with-tests
to
master
DenTray
requested changes
Dec 23, 2024
src/Generators/ModelGenerator.php
Outdated
| @@ -60,8 +60,8 @@ public function prepareRelatedModels(): void | |||
| if (!$this->classExists('models', $relation)) { | |||
| $this->throwFailureException( | |||
| ClassNotExistsException::class, | |||
There was a problem hiding this comment.
please add arg names for multiline style
| ]); | ||
| } | ||
|
|
||
| public function mockGeneratorForMissingRelationModel(): void |
There was a problem hiding this comment.
seems this method is not using
| { | ||
| return $this->hasMany(User::class); | ||
| } | ||
| protected $casts = [ |
There was a problem hiding this comment.
could we change casts place after the hidden property
| { | ||
| public function some_relation() | ||
| { | ||
|
|
refs: #49
…to 49-add-model-generator-tests
DenTray
requested changes
Jan 13, 2025
| @@ -0,0 +1,10 @@ | |||
| <?php | |||
There was a problem hiding this comment.
could we use this model https://github.com/RonasIT/laravel-entity-generator/blob/master/tests/Support/Models/WelcomeBonus.php and just add relation to there instead?
| @@ -28,6 +28,8 @@ public function setUp(): void | |||
|
|
|||
| vfsStream::setup(); | |||
|
|
|||
| Event::fake(); | |||
There was a problem hiding this comment.
it's good to move it to the base test case class, but please remove event fake from other tests classes
tests/ModelGeneratorTest.php
Outdated
|
|
||
| class ModelGeneratorTest extends TestCase | ||
| { | ||
| use ModelMockTrait, MockTrait; |
There was a problem hiding this comment.
could we just use MockTrait into Generator MockTrait?
refs: #49
DenTray
requested changes
Jan 14, 2025
src/Generators/ModelGenerator.php
Outdated
| ); | ||
| } | ||
|
|
||
| if ($this->isStubExists('model') && ($this->isStubExists('relation') || empty($this->relations))) { | ||
| if ($this->isStubExists('model') && (collect($this->relations)->every(fn ($relation) => empty($relation)) || $this->isStubExists('relation', 'model'))) { |
There was a problem hiding this comment.
Suggested change
| if ($this->isStubExists('model') && (collect($this->relations)->every(fn ($relation) => empty($relation)) || $this->isStubExists('relation', 'model'))) { | |
| if ($this->isStubExists('model') && (!$this->hasRelations() || $this->isStubExists('relation', 'model'))) { |
refs: #49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #49