Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct namespace for models accordingly to the package config #100

Open
DenTray opened this issue Nov 12, 2024 · 2 comments
Open

Use correct namespace for models accordingly to the package config #100

DenTray opened this issue Nov 12, 2024 · 2 comments
Assignees
Milestone

Comments

@DenTray
Copy link
Collaborator

DenTray commented Nov 12, 2024

In AbstractTestGenerator need to change the getModelClass logic. Instead of hardcoded App\Models namespace should be generated accordingly package config paths.models transformed to PSR4 standard.

After implementation, namespace binding in composer ("App\Models": "tests/Support/Models") should be removed and related test cases should modify path in config instead.

@DenTray DenTray added this to the 3.3 milestone Nov 27, 2024
pirs1337 added a commit that referenced this issue Nov 28, 2024
pirs1337 added a commit that referenced this issue Nov 28, 2024
pirs1337 added a commit that referenced this issue Nov 29, 2024
pirs1337 added a commit that referenced this issue Nov 29, 2024
@pirs1337
Copy link
Contributor

pirs1337 commented Dec 3, 2024

done

@pirs1337 pirs1337 assigned DenTray and unassigned pirs1337 Dec 3, 2024
@DenTray
Copy link
Collaborator Author

DenTray commented Dec 9, 2024

@pirs1337 I've modify my local config

image

and try to generate new entity

image

could you please check it?

@DenTray DenTray assigned pirs1337 and unassigned DenTray Dec 9, 2024
pirs1337 added a commit that referenced this issue Dec 10, 2024
@DenTray DenTray modified the milestones: 3.3, 3.4 Dec 12, 2024
pirs1337 added a commit that referenced this issue Dec 17, 2024
pirs1337 added a commit that referenced this issue Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants