Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Option to resize screen and buttons on Android #8

Open
Greggggggggggg opened this issue Sep 3, 2023 · 5 comments

Comments

@Greggggggggggg
Copy link

Greggggggggggg commented Sep 3, 2023

I've tested your emulator on Android, and so far it's working perfectly.

The only small problems I have are the size of the screen, which could be enlarged to take full advantage of the screen of my phone, and the size of the buttons, which are inconvenient because of their small size.

An option to resize the screen of the games and the size of the buttons to adapt to bigger Android phones would be nice.

This is my humbly request

@Rodrigodd
Copy link
Owner

Hi, it may take me a while for implementing that, because first I need to create the entire options screen.

But maybe your problem is more related on how poorly I may be handling DPI scaling, or scaling in general. Can you share a screenshot showing the size of the buttons? And maybe your phone model, if possible. This problem may be easier to fix than the options screen.

@Greggggggggggg
Copy link
Author

Greggggggggggg commented Sep 4, 2023

Hi, my phone model is an Google Pixel 7

Screenshot_gameroy_pokemon_cramorant

Sorry about the closed and reopened, I missclicked

@Rodrigodd
Copy link
Owner

It is what I suspected, the program is not currently handling your DPI scale. I am only handling 1x and 2x right now. I will try to implement the remaining DPI scales from Android's documentation (0.75x, 1.5x, 3x and 4x) to see if it brings an improvement.

But I also suspect that I will need to scale the buttons in directly proportion to the screen instead.

Regarding the screen, I am currently limiting its scaling to an integer to make the scaling pixel perfect. But I don't think this is desirable in this case.

@Rodrigodd
Copy link
Owner

I was able to reproduce this on a emulator.

On 7df36c2 I implement all android bitmap scaling variants. Google Pixel 7 is using the 3x variant.

On 8755617 I put the integer scaling behind a configuration value (currently you can only change it on native) and let the default be disable. So on Android, now this should always scale to fit the total screen size.

@Greggggggggggg does it look better for you? But this was only a visual change, the touch-response radius of each button is still the same. You can download this new version from the last Github Actions CI Artifacts. Let me know if it feels better know, or I still need to increase the response radius (I could not test this on a emulator).

Before After
Screenshot_20230913_181605 Screenshot_20230913_180352

@Greggggggggggg
Copy link
Author

I tried it, and it's exactly like in your right screenshot, and it feels much better ! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants