[multibody] Remove dynamic_cast from inline get-downcast functions #22209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
added
priority: low
status: single reviewer ok
jwnimmer-tri
force-pushed
the
mbt-no-dynamic-cast
branch
from
f484322
to
edb1cd5
Compare
jwnimmer-tri
force-pushed
the
mbt-no-dynamic-cast
branch
from
edb1cd5
to
12583d3
Compare
|
FYI @rpoyner-tri I am not going to try to get this reviewed and merged until next week, but in case it helps your testing feel free to cherry-pick it for now. |
rpoyner-tri
reviewed
Nov 22, 2024
There was a problem hiding this comment.
As pleasant as all of this is, I suspect it is irrelevant. See #22227.
Reviewable status: needs platform reviewer assigned, needs at least one assigned reviewer (waiting on @jwnimmer-tri)
|
This isn't a fix for macOS, it is a fix for styleguide compliance / compilation speed. We can debate if hewing to the style guide this assiduously is worth this level of complexity, but the specifics of XCode are mostly irrelevant here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dynamic_castoperation does not meet our styleguide requirements for being inline. We need to move the definitions to the cc files.This change is tangentially inspired by #22204.
This change is