RenderEngineVtk can be forced into PBR mode

[SeanCurtis-TRI]

Adds a new parameter to RenderEngineVtkParams. Rather than waiting for the engine's lighting model to get promoted based on its content, it can be pushed into that mode upon construction.

This also fixes a bug in which cloned instances forgot whether or not phong materials should be automatically promoted to PBR.

---

This change is 

[SeanCurtis-TRI]

+(release notes: feature) for the new RenderEngineVtkParams field.
+(release notes: fix) for the correction in post-clone behavior.

Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers

[jwnimmer-tri]

FYI The change-detector test render_engine_vtk_params_test needs a small fix now for CI.

[SeanCurtis-TRI]

-- commits line 15 at r2:
This introduces some cruft so I could better assess the nature of the CI test failure.

[SeanCurtis-TRI]

Blast! Schrodinger's CI strikes again. Instrumenting it so I could see the cause of failure, made the failure go away. :-P I'm going to try some quick variants to see where the transition is.

Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @SeanCurtis-TRI)

[SeanCurtis-TRI]

Reviewable status: 2 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @SeanCurtis-TRI)

---

geometry/render_vtk/test/internal_render_engine_vtk_test.cc line 2128 at r3 (raw file):

  Render(__LINE__, "clone with ball", clone, &camera, &clone_image, &depth,
         &label);
  EXPECT_EQ(clone_image, pbr_image);

Increasing the image size and removing the streaming, the test passed in R3. So, if we go all the way back to the original image size, what happens next?

[SeanCurtis-TRI]

Reviewable status: 2 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @SeanCurtis-TRI)

---

geometry/render_vtk/test/internal_render_engine_vtk_test.cc line 2128 at r3 (raw file):

Previously, SeanCurtis-TRI (Sean Curtis) wrote…

Increasing the image size and removing the streaming, the test passed in R3. So, if we go all the way back to the original image size, what happens next?

It fails at the original size....

[rpoyner-tri]

Good day, @SeanCurtis-TRI . This PR does not yet have a reviewer assigned. Is it ready for review yet? If yes, then please assign a feature reviewer. If not, then please label it “status: do not review”.

Reviewable status: 2 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @SeanCurtis-TRI)

[SeanCurtis-TRI]

Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers

---

geometry/render_vtk/test/internal_render_engine_vtk_test.cc line 2128 at r3 (raw file):

Previously, SeanCurtis-TRI (Sean Curtis) wrote…

It fails at the original size....

For now, a todo and a reduced size.

[SeanCurtis-TRI]

-(status: do not review)

[sherm1]

Is this ready for feature review now, Sean?

[SeanCurtis-TRI]

+@zachfang for feature review, please.

Reviewable status: LGTM missing from assignee zachfang, needs platform reviewer assigned, needs at least two assigned reviewers

[zachfang]

feature.

Reviewed 2 of 3 files at r1, 1 of 3 files at r2, 2 of 2 files at r5.
Reviewable status: 2 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers

---

geometry/render_vtk/test/internal_render_engine_vtk_test.cc line 1966 at r5 (raw file):

//  3. RenderEngineVtkParams::force_to_pbr is set to `true`.
//
// (1) is confirmed by this test.

nit.

Suggestion:

Is confirmed

---

geometry/render_vtk/test/internal_render_engine_vtk_test.cc line 2042 at r5 (raw file):

// a promotion criterion.
TEST_F(RenderEngineVtkTest, PbrMaterialSettingSurvivesCloning) {
  // TODO(SeanCurtis-TRI) Inexplicably, the full size (640x480) cameras causes

nit. camera causes or cameras cause.

Code quote:

 cameras causes