Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Insert next sentence prediction questions #83

Open
JackMostow opened this issue Dec 7, 2021 · 6 comments
Open

Feature request: Insert next sentence prediction questions #83

JackMostow opened this issue Dec 7, 2021 · 6 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed HIGH PRIORITY

Comments

@JackMostow
Copy link
Contributor

Describe the solution you'd like
Insert next-sentence prediction questions .

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Approach to be followed (optional)
Adapt animator graph and code for inserting cloze questions.

Additional context
Nishi generated nsp questions for English and Swahili stories here using Jingrong's coherence evaluator.
Mason already adapted the story questions animator graph in the nsp_ag tab of this diagram here.
His draft code needs to be pushed to the nsp_questions branch.

@JackMostow
Copy link
Contributor Author

Mason stopped working on this task.
To do:
Push RoboTutor_2020/app/src/main/assets/tutors/story_questions/animator_graph.json
displayNextSentencePredictorQuestion
https://github.com/RoboTutorLLC/RoboTutor_2020/blob/bfa7cc68b00edda06dac0eb8756b1fb81b5318ad/comp_questions/src/main/java/cmu/xprize/comp_questions/CQn_ViewManagerASB.java (line 2513)
TQn Component
CQn Component
NSP classes (ex. NSPQuestions.java, NSPContextQuestion.java, etc.)
Mason [ ] find spec of nsp UIUX in meeting notes
Which sentence(s)? (First, last, …)
Mason [ ] storyboard of show&say steps in T/F nsp display, answer, feedback
For T/F nsp
For which-sentence nsp

@JackMostow
Copy link
Contributor Author

Here's draft revision to RoboTutor_2020/app/src/main/assets/tutors/story_questions/animator_graph.json:
"NSP_PAGE_NODE": {
"type": "NODE",
"COMMENT": "When module is complete - move to next scene in the scenegraph",
"maptype": "moduleMap",
"mapname": "PAGEFLIP",
"preenter": ["SET_NSP_PAGE"],
"preexit": [],
"edges": [
{"constraint": "", "edge": "LISTEN"}
]
},

"PRESENT_NSP": {
"type": "NODE",
"COMMENT": "When module is complete - move to next scene in the scenegraph",
"maptype": "moduleMap",
"mapname": "DISPLAY_NSP_QUESTION",
"preenter": [],
"preexit": [],
"edges": [
{"constraint": "", "edge": "AWAIT_NSP_RESPONSE"}
]
},

"AWAIT_NSP_RESPONSE": {
"COMMENT": "",
"type": "NODE",
"preenter": [],
"maptype": "moduleMap",
"mapname": "LISTENING",
"preexit": [],
"edges": [
{"constraint":"NSP_CORRECT", "edge":"NSP_GOOD"},
{"constraint":"NSP_WRONG", "edge":"NSP_BAD"}
]
},

"NSP_GOOD": {
"COMMENT": "When user inputs a correct answer...",
"type": "NODE",
"maptype": "moduleMap",
"mapname": "PLAYCLOZECORRECT", -------> very confusing; pic-match also shares this; maybe bug?
"preenter": [],
"preexit": ["RESET_NSP_BUTTONS", "HIDE_NSP_BUTTONS"],
"edges": [
{"constraint": "", "edge": "NEXT_PAGE_NODE"}
]
},

"NSP_BAD": {
"COMMENT": "When user inputs an incorrect answer...",
"type": "NODE",
"maptype": "moduleMap",
"mapname": "PLAYCLOZEWRONG", -------> very confusing; pic-match also shares this; maybe bug?
"preenter": [],
"preexit": ["RESET_NSP_BUTTONS", "ENABLE_NSP_BUTTONS"],
"edges": [
{"constraint": "", "edge": "AWAIT_NSP_RESPONSE"}
]
},

@JackMostow
Copy link
Contributor Author

copy-and-adapt cloze question animator graph and Java component tor nsp.
What about UI/UX?
Cloze question choices are single words that fit on the right side of the screen
Nsp question choices are entire sentences that won’t. Where to put them?
Display instead of page text.
+: easiest because lotsa room
+: makes sense for “pre-page” questions because page not shown yet anyway.
Display below page text.
-: harder because might not fit
+: makes sense for end-of-page multiple choice
+: makes sense for candidate sentence with yes-no response
Display below page text, but one at a time, alternating
+: takes less space than 2 sentences
+: shows candidates where they’d actually appear
-: confusing?

Where to display “yes” and “no” as choices:
In right margin like cloze choices
Below candidate sentence

How to display “yes” and “no” as choices:
Swahili word buttons for “yes” (ndiyo) and “no” (hapana)
-: kids may not be able to read them
+: kids may learn them from RoboTutor reading them
++: easiest
Smiley and frowny icons like in FaceLogin
Nodding and shaking video clips
Tap on sentence if correct

@JackMostow JackMostow added the help wanted Extra attention is needed label Dec 29, 2021
@JackMostow
Copy link
Contributor Author

@madeleinvillegas - Please revert to 1482e6f.
Then reimplement the changes to 43 files as minimal edits to a minimal set of files to make them easier to understand and to avoid dangerous duplicated code. Thanks!

@JackMostow
Copy link
Contributor Author

Also, the edits should be on the nsp_question branch, not this branch.

@JackMostow
Copy link
Contributor Author

Constrain RoboTutor to enforce restrictions on where to insert NSP:
+: prevent unfortunate incidents
Only after first [3] sentences
Only before last [2] sentences → will need to know # sentences
Only before first sentence on page
+: finesse layout issues
-: limits opportunities to insert NSP on long pages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed HIGH PRIORITY
Projects
None yet
Development

No branches or pull requests

5 participants