Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Specify in config.json whether RoboTutor should make RoboFeel run and indicate whether it is. #70

Open
JackMostow opened this issue Jul 23, 2021 · 5 comments

Comments

@JackMostow
Copy link
Contributor

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is.
Specify whether RoboFeel should run whenever RoboTutor does.

Describe the solution you'd like
A clear and concise description of what you want to happen.

  1. Enable/disable RoboFeel in config.json.
  2. If enabled, start RoboFeel service when RoboTutor launches, and stop when it exits or crashes
  3. RoboTutor display whether RoboFeel is running.

Describe alternatives you've considered

  • Considered using 1 eye instead of 2, but 2 is more recognizable and we happen to have images that fit and match the banner.

  • Considered centering at bottom of screen, but too conspicuous and conflicts with other objects, e.g. Bubblepop stimulus.

  • Considered translucent eye(s) floating over screen, but harder to implement.

  • Considered testing whether RoboFeel is actually running, but harder to implement and negligible value added.

  • Considered tapping eye(s) to toggle RoboFeel, but it would be an attractive nuisance.

A clear and concise description of any alternative solutions or features you've considered.

Approach to be followed (optional)
A clear and concise description of approach to be followed.

Use these images:

  • When RoboFeel is enabled: 11 eyes half-open It looks bored but is static so it shouldn't distract the user.

  • When RoboFeel is disabled: 10 eyes closed

  • This image is too disruptive: 1 eyes open

  • This image is a possibility: 2 eyes looking left

Size: half the height of the green banner at the top of the screen

Location: on the right end of the banner, in the bottom half of the banner to avoid overlap with tutor ID

Additional context
Add any other context or screenshots about the feature request here.

See how to add a config variable at ConfigurationItems.java.

Use eye pair images from Eye Roll

@JackMostow
Copy link
Contributor Author

Modify RTFaceLogin to stop RoboFeel when recording selfies -- necessary only if RoboTutor crashes without stopping RoboFeel.

If we decide we want visual cues during RTFaceLogin, make it launch RoboFeel when it starts and after recording each selfie.

@JackMostow
Copy link
Contributor Author

How to create a branch enable_RoboFeel

Code for getting parameters from config.json
-- add Enable_RoboFeel analogous to enabling screen recording

-- see if screen recorder is a service (afraid not)
Google to find out:

How to start a service StartService()
How to stop a service StopService()

When to start:  at launch
When to stop:
	At exit
	At crash

	(only needed in case RoboTutor crashes without stopping RoboFeel) when RTFaceLogin starts or records video

@JackMostow
Copy link
Contributor Author

@AASTHAVALECHA @sushant-varanasi
I added a branch enable_robofeel for you to make the changes specified above. Please clone it and verify that you can push to it.

@JackMostow
Copy link
Contributor Author

@AASTHAVALECHA
Copy link
Collaborator

@sushant-varanasi I was facing a problem in pushing
In Oncreate Function
Write the code to start service, Component name specifies the package and the packagename.nameofservice that is Robofeel

Intent i = new Intent();
i.setComponent(new ComponentName("mayank.example.rtcamera", "mayank.example.rtcamera.RoboService"));
startService(i);

In Ondestroy
Write the code to stop service, Component name specifies the package and the packagename.nameofservice that is Robofeel

//Stop Service

Intent i = new Intent();
i.setComponent(new ComponentName("mayank.example.rtcamera", "mayank.example.rtcamera.RoboService"));
stopService(I);

I made the following changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants