Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: ignore unknown variables in config.json #107

Open
JackMostow opened this issue Sep 22, 2022 · 0 comments
Open

Feature request: ignore unknown variables in config.json #107

JackMostow opened this issue Sep 22, 2022 · 0 comments
Assignees

Comments

@JackMostow
Copy link
Contributor

JackMostow commented Sep 22, 2022

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is:
Unknown variables in config.json cause an error (true?).

Describe the solution you'd like
A clear and concise description of what you want to happen.
Ignore them. Perhaps log the ignored variable and value.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Approach to be followed (optional)
A clear and concise description of approach to be followed.
Just add a catch-all case to the config.json parser.
Also, make sure configuration classes are accessible throughout RoboTutor.

Additional context
Configuration classes are located in: https://github.com/RoboTutorLLC/RoboTutor_2020/tree/development/app/src/main/java/cmu/xprize/robotutor/startup/configuration
While NSP questions are located in:
https://github.com/RoboTutorLLC/RoboTutor_2020/tree/development/comp_questions/src/main/java/cmu/xprize/comp_questions

What is currently in the NSP questions is the config.json is read again with only the necessary NSP-related items since the Configuration classes cannot be accessed in comp_questions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants