Make table form of mapDispatchToProps work with callable table actionCreators #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonycuadra
commented
Oct 8, 2024
| @@ -164,20 +172,20 @@ local function connect<StoreState, Props, MappedStatePartialProps, MappedDispatc | |||
| end | |||
|
|
|||
| local mappedStoreDispatch: any | |||
| if mapDispatchType == "table" then | |||
| if isCallable(mapDispatchToProps) then | |||
There was a problem hiding this comment.
I swapped the order of the if / elseif checks here because a table can still be callable
jkelaty-rbx
approved these changes
Oct 8, 2024
|
I got all the static checks passing again but it looks like I don't have permission to merge the change in this repo. @jkelaty-rbx can you merge? |
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.