alsa: hardcode S16_LE sample format

Audio sample format from sound card is endian-independent.
RoEdAl · Nov 2, 2023 · 1e8f603 · 1e8f603
1 parent 723520c
commit 1e8f603
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/src/chan_quectel.c b/src/chan_quectel.c
@@ -208,7 +208,7 @@ static int pcm_init(struct pvt* pvt, const char* dev, snd_pcm_stream_t stream, c
         goto alsa_fail;
     }
 
-    res = snd_pcm_hw_params_set_format(handle, hwparams, format);
+    res = snd_pcm_hw_params_set_format(handle, hwparams, pcm_format);
     if (res < 0) {
         ast_log(LOG_ERROR, "[%s][ALSA][%s] HW Set format failed: %s\n", PVT_ID(pvt), stream_str, snd_strerror(res));
         goto alsa_fail;

diff --git a/src/chan_quectel.h b/src/chan_quectel.h
@@ -29,13 +29,8 @@
 #include "cpvt.h"      /* struct cpvt */
 #include "dc_config.h" /* pvt_config_t */
 
-#define ALSA_PCM_NEW_HW_PARAMS_API
-#define ALSA_PCM_NEW_SW_PARAMS_API
-#if __BYTE_ORDER == __LITTLE_ENDIAN
-static const snd_pcm_format_t format = SND_PCM_FORMAT_S16_LE;
-#else
-static const snd_pcm_format_t format = SND_PCM_FORMAT_S16_BE;
-#endif
+static const snd_pcm_format_t pcm_format = SND_PCM_FORMAT_S16_LE;
+
 #define MAX_BUFFER_SIZE 100
 #define MODULE_DESCRIPTION "Channel Driver for Mobile Telephony"
 #define MAXQUECTELDEVICES 128