Bug/778 #2
Open
Bug/778 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emaRegistryClient to be specified (confluentinc#731)
Change Slack channel to connect team
* CLIENTS-986 Forward Auth headers
This reverts commit 380bdfb.
* Add link from Schema Registry docs to cp-demo * DOCS-385: Addressing comments from Joel
…figs and allow unprefixed versions (confluentinc#837) * Deprecate schema.registry. prefixed resource extension class config and provide unprefixed version * Deprecate schema.registry. prefixed inter instance protocol config and provide unprefixed version * Deprecate schema.registry. prefixed basic.auth.user.info config and provide unprefixed version * fix tests with Java 10
…nt change took away the by subject cache. This will do that again when we need schema versions. (confluentinc#839)
dcsobral
force-pushed
the
bug/778
branch
2 times, most recently
from
0e30415 to
781c2e6
Compare
Because fixed can appear multiple times in an enum, being a named type, enough information must be preserved to correctly identify the union index, which is mostly easily managed by simply reifying fixed types with their name and size.
When setting default values for unions, encapsulate the value inside a struct so that it matches the schema to which the default value is being assigned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This had to be based on top of bug/776 or there would have been conflicts merging both. I'll submit a single PR to Confluent fixing both bugs at the same time, I suppose.