Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this module is not compatible with nginx v1-24-0 #14

Open
ghost opened this issue May 3, 2023 · 6 comments
Open

this module is not compatible with nginx v1-24-0 #14

ghost opened this issue May 3, 2023 · 6 comments

Comments

@ghost
Copy link

ghost commented May 3, 2023

Hi,
I want to make nginx 1-24-0 using nginx-sticky-module-ng. but it has some errors:
1- error: ‘ngx_http_headers_in_t’ has no member named ‘cookies’; did you mean ‘cookie’?
243 | if (ngx_http_parse_multi_header_lines(&r->headers_in.cookies, &iphp->sticky_conf->cookie_name, &route) != NGX_DECLINED) {
2- error: passing argument 2 of ‘ngx_http_parse_multi_header_lines’ from incompatible pointer type [-Werror=incompatible-pointer-types]
243 | if (ngx_http_parse_multi_header_lines(&r->headers_in.cookies, &iphp->sticky_conf->cookie_name, &route) != NGX_DECLINED) {
3- error: too few arguments to function ‘ngx_http_parse_multi_header_lines’
243 | if (ngx_http_parse_multi_header_lines(&r->headers_in.cookies, &iphp->sticky_conf->cookie_name, &route) != NGX_DECLINED) {
4- error: ‘ngx_http_upstream_headers_in_t’ has no member named ‘cookies’
475 | if (ngx_http_parse_set_cookie_lines(&r->upstream->headers_in.cookies, &ctx->sticky_conf->cookie_name, &transfer_cookie) == NGX_DECLINED)
5- error: passing argument 2 of ‘ngx_http_parse_set_cookie_lines’ from incompatible pointer type [-Werror=incompatible-pointer-types]
475 | if (ngx_http_parse_set_cookie_lines(&r->upstream->headers_in.cookies, &ctx->sticky_conf->cookie_name, &transfer_cookie) == NGX_DECLINED)
6- error: too few arguments to function ‘ngx_http_parse_set_cookie_lines’
475 | if (ngx_http_parse_set_cookie_lines(&r->upstream->headers_in.cookies, &ctx->sticky_conf->cookie_name, &transfer_cookie) == NGX_DECLINED)

in https://trac.nginx.org/nginx/ticket/2358 an error like the errors that are mentioned here is investigated. ( This includes the explicitly mentioned change to use linked lists instead of arrays, as well as various renames to match the new approach to headers. For the details about the particular change causing the build failure, see ef6a3a99a81a. The 3rd party modules you are using need to be adjust to work with nginx 1.23.0.)

I need to have this module with nginx. if it is possible, please resolve it. thank you.

@Gokul-Rams
Copy link

I am also facing same issue when building nginx image with nginx version post 1.23
Is there any possibility of fixing this issue providing compatability with latest nginx versions

@rickygm
Copy link

rickygm commented May 17, 2023

does not compile with nginx 1.24:

c1: all warnings being treated as errors
make[1]: *** [objs/Makefile:2226: objs/addon/nginx-sticky-module-ng/ngx_http_sticky_module.o] Error 1
make[1]: Leaving directory '/rpm/nginx-1.24.0'
make: *** [Makefile:10: build] Error 2

@xuges
Copy link

xuges commented Sep 13, 2023

@ssh81 This issue was resolved on my fork: https://github.com/xu2ge/nginx-sticky-module-ng
you also can see my pull request: #17

@rickygm
Copy link

rickygm commented Sep 13, 2023

works perfect my friend

@ghost
Copy link
Author

ghost commented Sep 13, 2023

@ssh81 This issue was resolved on my fork: https://github.com/xu2ge/nginx-sticky-module-ng you also can see my pull request: #17

Thank you :)

@devhaozi
Copy link

devhaozi commented Dec 10, 2023

@Refinitiv Can you please check and merge this fix?
@JonathanHuot @vkaidalov-rft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants