Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

android: Use buildToolsVersion from ANDROID_BUILD_TOOLS_VERSION env variable #132

Closed
osipxd opened this issue Apr 19, 2023 · 0 comments · Fixed by #138
Closed

android: Use buildToolsVersion from ANDROID_BUILD_TOOLS_VERSION env variable #132

osipxd opened this issue Apr 19, 2023 · 0 comments · Fixed by #138
Labels
enhancement New feature or request
Milestone
v0.19

Comments

@osipxd
Copy link
Collaborator

osipxd commented Apr 19, 2023 •
edited
Loading

We should use value from ANDROID_BUILD_TOOLS_VERSION if it is specified. It may be useful on CI to use installed version of build tools.
Here:

gradle-infrastructure/infrastructure-android/src/main/kotlin/android/AndroidOptionsImpl.kt

Lines 27 to 28 in fb93711

buildToolsVersion
.finalizeValueOnRead()

@osipxd osipxd added this to the Next milestone Apr 19, 2023
@osipxd osipxd added the enhancement New feature or request label Apr 19, 2023
osipxd added a commit that referenced this issue Jul 10, 2024
@osipxd
android: Use ANDROID_BUILD_TOOLS_VERSION env variable for `buildToo…
937148a 
…lsVersion`

Closes #132
@osipxd osipxd mentioned this issue Jul 10, 2024
Merged
@osipxd osipxd linked a pull request Jul 10, 2024 that will close this issue
Cleaning #138
Merged
@osipxd osipxd closed this as completed Jul 24, 2024
@osipxd osipxd mentioned this issue Jul 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.19
Development

Successfully merging a pull request may close this issue.

Cleaning RedMadRobot/gradle-infrastructure
1 participant
@osipxd