-
Notifications
You must be signed in to change notification settings - Fork 1
GRIF-209: refactor products-contains-component output and added --include-container-roots #281
Conversation
Tested and it works great. Table nicely corresponds with the actual output. One problem might be when using middleware CLI from Griffon for Maven stuff I get:
Might need some special handling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of questions and the -r
render problem as per slack discussion
-r works for me ex. griffon service products-contain-component -r 'webkit(2|3)gtk' -vv |
I would like to also verify this again once Corgi stage/prod performance issues are resolved. |
8f01205
to
1dfbd03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I would still like to verify the -r before the approval.
675757b
to
03d9d6e
Compare
03d9d6e
to
944713e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
a heavy refactor of output from services products-contains-components
where the -v and -vv options summarise versions, types and arches of children components. The -vvv option lists out each child component without summarising. The -vvvv option emits purls.
also