create EndorsementController #41

bhtibrewal · 2023-11-23T16:27:11Z

Issue Ticket

Closes: #28

Description

Create postEndorsement API endpoint

Test

Follow-up :

#80

skill-tree /src/main/java/com/RDS/skilltree/EndorsementList/EndorsementListDRO.java

skill-tree /src/main/java/com/RDS/skilltree/EndorsementList/EndorsementListService.java

debanjanc01 · 2023-11-26T16:46:42Z

skill-tree /src/main/java/com/RDS/skilltree/EndorsementList/EndorsementListService.java

+
+        } else {
+            if (endorserOptional.isEmpty())
+                throw new NoEntityException("User with id:" + endorserId + "not found");


This seems to be an error as there are two throw new statements. Did you mean to throw NoEntityException for no endorsement?
Also, in the error message try to have spaces after the strings for concatenation. Otherwise for id: 123 your message will look like endorsement with id:123not found

no the endorser is checked as empty here hence user not found exception

debanjanc01 · 2023-11-26T16:47:44Z

skill-tree /src/main/java/com/RDS/skilltree/Exceptions/NoEntityException.java

@@ -0,0 +1,12 @@
+package com.RDS.skilltree.Exceptions;
+
+public class NoEntityException extends RuntimeException {


Is there a reason why this is a RuntimeException and not Exception?

An Exception is checked, and a RuntimeException is unchecked.

Checked means that the compiler requires that you handle the exception in a catch, or declare your method as throwing it (or one of its superclasses).

Generally, throw a checked exception if the caller of the API is expected to handle the exception, and an unchecked exception if it is something the caller would not normally be able to handle, such as an error with one of the parameters, i.e. a programming mistake.

So here we are using these error to throw error for things the caller API couldn't have checked before hand like, "no user foiund for this user id " etc

@bhtibrewal and @debanjanc01 what about overwriting the stack trace in case of check and un-checked (question for both)

@iamitprakash if you're talking about custom exceptions, then in my opinion it depends on how the exception is being used.

If it's Exceptions that ultimately propagates directly to the Controller and is handled by a global exception handler, then the stack trace can be suppressed. The assumption here is that the exception handler will be sending the correct response to the API caller.

If it's Exceptions that are being used internally, and handled via Catch statements, we might want to error log with the stacktrace.

I don't the knowledge on this topic, need to read more

skill-tree /src/test/java/com/RDS/skilltree/EndorsementsIntegrationTests.java

skill-tree /src/main/java/com/RDS/skilltree/Endorsement/EndorsementController.java

skill-tree /src/main/java/com/RDS/skilltree/Endorsement/EndorsementDTO.java

skill-tree /src/main/java/com/RDS/skilltree/Endorsement/EndorsementService.java

skill-tree /src/main/java/com/RDS/skilltree/EndorsementList/EndorsementListDRO.java

skill-tree /src/main/java/com/RDS/skilltree/EndorsementList/EndorsementListDTO.java

skill-tree /src/main/java/com/RDS/skilltree/EndorsementList/EndorsementListService.java

skill-tree /src/test/java/com/RDS/skilltree/EndorsementsIntegrationTests.java

…orsementAPI

skill-tree /src/main/java/com/RDS/skilltree/Endorsement/EndorsementController.java

iamitprakash · 2023-12-05T18:22:59Z

skill-tree /src/main/java/com/RDS/skilltree/Exceptions/NoEntityException.java

@@ -0,0 +1,12 @@
+package com.RDS.skilltree.Exceptions;
+
+public class NoEntityException extends RuntimeException {


@bhtibrewal and @debanjanc01 what about overwriting the stack trace in case of check and un-checked (question for both)

skill-tree /src/main/resources/application.properties

skill-tree /src/main/java/com/RDS/skilltree/Endorsement/EndorsementDRO.java

debanjanc01 · 2023-12-05T19:34:38Z

skill-tree /src/main/java/com/RDS/skilltree/Skill/SkillModel.java

@@ -31,7 +31,7 @@ public class SkillModel extends TrackedProperties {
    private SkillType type = SkillType.ATOMIC;

    @Column(name = "is_deleted", nullable = false)
-    private boolean deleted;
+    private boolean deleted = false;


Isn't boolean false by default?

yes thanks for pointing out wasn't aware, removed it

debanjanc01 · 2023-12-09T15:38:31Z

skill-tree /src/main/java/com/RDS/skilltree/User/UserController.java

@@ -0,0 +1,4 @@
+package com.RDS.skilltree.User;
+
+public class UserController {


Any use for this class?

This is there in different PR, we can remove this @bhtibrewal

…e-backend into postEndorsementAPI

vikhyat187 · 2023-12-30T06:12:24Z

skill-tree/src/test/java/com/RDS/skilltree/unit/EndorsementListServiceTest.java

+
+        // Assertions
+        assertNotNull(result);
+        assertEquals(endorserId, result.getEndorser().getId());


Can you also print some message, to demonstrate what failed in the assert statements.

vikhyat187 · 2023-12-30T06:12:52Z

@bhtibrewal can you also write the integration tests please.

skill-tree/src/main/java/com/RDS/skilltree/Endorsement/EndorsementController.java

bhtibrewal added 9 commits November 23, 2023 21:56

create EndorsementController

0fdea86

add env to ignore

9a89d07

add DTO and DROs

0d0aa10

de.env

3175cc6

merge branch update_model

c9af284

create EndorsementListController

e90b5f2

remove EndorsementListController

d1faad5

add EndorsementServiceTest.java

c0e211e

Merge branch 'develop' into postEndorsementAPI

39cf6f9

debanjanc01 reviewed Nov 26, 2023

View reviewed changes

skill-tree /src/main/java/com/RDS/skilltree/EndorsementList/EndorsementListDRO.java Outdated Show resolved Hide resolved

debanjanc01 reviewed Nov 26, 2023

View reviewed changes

skill-tree /src/main/java/com/RDS/skilltree/EndorsementList/EndorsementListService.java Outdated Show resolved Hide resolved

debanjanc01 reviewed Nov 26, 2023

View reviewed changes

skill-tree /src/test/java/com/RDS/skilltree/EndorsementsIntegrationTests.java Outdated Show resolved Hide resolved

iamitprakash requested changes Nov 28, 2023

View reviewed changes

heyrandhir assigned bhtibrewal Nov 29, 2023

bhtibrewal added 4 commits December 1, 2023 23:42

add JsonManagedReference

1f6c2d4

Merge remote-tracking branch 'origin/postEndorsementAPI' into postEnd…

ca1b171

…orsementAPI

address some review comments

0fde179

added validation checks

a8a2e5e

iamitprakash reviewed Dec 5, 2023

View reviewed changes

iamitprakash requested changes Dec 5, 2023

View reviewed changes

skill-tree /src/main/resources/application.properties Outdated Show resolved Hide resolved

skill-tree /src/main/java/com/RDS/skilltree/Endorsement/EndorsementDRO.java Outdated Show resolved Hide resolved

debanjanc01 reviewed Dec 5, 2023

View reviewed changes

bhtibrewal added 7 commits December 6, 2023 21:04

remove extra entries in EndorsementDRO.java

e867d0f

handle NoEntityException

be11ae5

add DB_NAME variable in application.properties

2b17be2

handle exceptions in one catch block

3cacabe

made ApiResponse class

2e8bbe0

handle NoEntityException exception globally

2084c09

remove default false

d89effd

debanjanc01 previously approved these changes Dec 9, 2023

View reviewed changes

heyrandhir mentioned this pull request Dec 14, 2023

Adds Get Endorsement End Point #40

Merged

8 tasks

Merge branch 'develop' of https://github.com/Real-Dev-Squad/skill-tre…

ba72dd8

…e-backend into postEndorsementAPI

bhtibrewal dismissed debanjanc01’s stale review via ba72dd8 December 29, 2023 17:43

bhtibrewal added 3 commits December 29, 2023 23:30

merge the tests

08bf445

delete usused files

77f7110

fix build, add missing imports

5742947

vikhyat187 reviewed Dec 30, 2023

View reviewed changes

iamitprakash previously approved these changes Dec 30, 2023

View reviewed changes

iamitprakash self-requested a review December 30, 2023 09:23

fix EndorsementListServiceTest

c5a09ca

bhtibrewal dismissed iamitprakash’s stale review via c5a09ca December 30, 2023 10:27

bhtibrewal added 7 commits December 30, 2023 16:37

fix testCreateEndorsement test

f4cbbbd

revert change

05237e6

add integration test

717f24d

update integration test

eae68d5

update integration test

9ed6eb3

revert integration test

f3f9894

fix integration test

bb7ae49

vikhyat187 reviewed Dec 31, 2023

View reviewed changes

skill-tree/src/main/java/com/RDS/skilltree/Endorsement/EndorsementController.java Outdated Show resolved Hide resolved

bhtibrewal added 2 commits December 31, 2023 18:20

use GenericResponse

2fab76d

fix return type

3acd3d5

vikhyat187 reviewed Dec 31, 2023

View reviewed changes

skill-tree/src/main/java/com/RDS/skilltree/Endorsement/EndorsementController.java Outdated Show resolved Hide resolved

change endorsementModel to EndorsementDTO.toDto

d90443f

vikhyat187 approved these changes Dec 31, 2023

View reviewed changes

iamitprakash merged commit cfe9421 into develop Dec 31, 2023
1 check passed

iamitprakash deleted the postEndorsementAPI branch December 31, 2023 13:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

create EndorsementController #41

create EndorsementController #41

bhtibrewal commented Nov 23, 2023 •

edited

Loading

debanjanc01 Nov 26, 2023

bhtibrewal Dec 3, 2023

debanjanc01 Nov 26, 2023

bhtibrewal Dec 4, 2023

iamitprakash Dec 5, 2023

debanjanc01 Dec 5, 2023 •

edited

Loading

bhtibrewal Dec 7, 2023

iamitprakash Dec 5, 2023

debanjanc01 Dec 5, 2023

bhtibrewal Dec 7, 2023

debanjanc01 Dec 9, 2023

vikhyat187 Dec 10, 2023

vikhyat187 Dec 30, 2023

vikhyat187 commented Dec 30, 2023

		@@ -0,0 +1,12 @@
		package com.RDS.skilltree.Exceptions;

		public class NoEntityException extends RuntimeException {

		@@ -0,0 +1,4 @@
		package com.RDS.skilltree.User;

		public class UserController {

create EndorsementController #41

create EndorsementController #41

Conversation

bhtibrewal commented Nov 23, 2023 • edited Loading

Issue Ticket

Description

Test

Follow-up :

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

debanjanc01 Dec 5, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vikhyat187 commented Dec 30, 2023

bhtibrewal commented Nov 23, 2023 •

edited

Loading

debanjanc01 Dec 5, 2023 •

edited

Loading