build api to approve/reject skill request #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamitprakash
approved these changes
Aug 4, 2024
prakashchoudhary07
added a commit
that referenced
this pull request
Aug 5, 2024
* create a model to store user_skill and add remove unused columns in users and skills model * create a model to store user_skill and add/remove unused columns in users and skills model * change id to integer * check if a skill already exists before creating one, make `updated_at` optional in TrackedProperties * remove unit and integration test and remove skill service & skill service implementation * add todo * rename SkillType to SkillTypeEnum * set logging level debug in application-dev instead of application * add todo * remove endorsements list * add reference to user table in skills modal * Build api to create a new endorsement * create api to update an endorsement * remove unused files * remove unused code in endorsement controller * chagne import order * change the skills project structure to match the new one * rename exceptions folder to small case exceptions and create user not found and skill already exists exceptions * create enums folder and move skill type enum to the folder * rename Conifg to config, move generic response and jwtAuthenticationFilter to utils * add api to get all endorsements for a skill using skill id in skillsapi * remove skills package * fix build error * move api to create a endorsement to the new folder structure * add api to update endorsement in apis/endorsements api and remove old Endorsement folder * move health check api to the api folder & metric service inside the services folder * fix formatting * create annotation and aspect to handle authorized roles to an api * add authorizred roles annotation to skillsapi & endorsementsapi class * set authorized role for creating a skill to only superuser * fix formatting * create api to get all skill requests * apply spotless * set endorsement id * run spotlesscheck * remove comments * add super user role check in skills/requests api * build the `skill/requests` api to get all skill requests and their endorsements * fix duplicate data issue when getting all skill requests * improve comment * change data to requests in SkillRequestDto * fix formatting * fix wrong id being set in endorserDetails * fix formatting error * create api to login via rds backend * add permitted paths to security config * fix formatting * change permitted routes to non auth routes * improve the internal server error exception handler by adding time stamp, error message and details * fix formatting * remove user table and use RdsUserViewModel instead * remove auth api and fix logging in update endorsement api * fix formatting * change EndorsementViewModel to use builder pattern * Remove commented code * Change error to info * Refactor: Move post endorsements in skills route (#143) * build api to approve/reject skill request (#144) * build api to approve/reject skill request * fix formatting --------- Co-authored-by: Prakash <[email protected]> Co-authored-by: Prakash Choudhary <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 04 August 2024
Developer Name: yash raj
Issue Ticket Number
Description
v1/skills/requests/{skillId}/actionAPI toapprove / rejecta skill request.Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Test Coverage
Screenshot 1
Additional Notes