-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Swipe controls): Add option to enable/disable fullscreen swipe to next video #4222
feat(Swipe controls): Add option to enable/disable fullscreen swipe to next video #4222
Conversation
@oSumAtrIX Should the swipe gestures be changed to default off? I don't think the feature is intuitive enough to have it on by default. Users won't know that swiping will change volume/brightness, and if they do swipe it's likely by accident and they won't realize the behavior is a patch feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be a separate patch. The swipe controls patch may conflict with the gesture and depend on that patch, however users may want to use that patch without the swipe gestures patch.
Sure, alternatively a first use toast/dialog could be shown and inform the user that they triggered swipe gestures which can be toggled on or off in the settings. |
I'll extract to a different patch and change swipe volume/brightness to default off. Someone else should verify if this patch clashes with volume/brightness swipe. I don't use swipe volume/brightness and everytime I try I think the patch is broken because it never behaves how I expect 🤷🏼♂️ |
I'm about to change this to something like Swiping to change volume/brightness/video are all identical, except swiping to the next video is a YT feature. Maybe this should remain part of If the swipe for next video becomes standard, then it can be extracted to it's own |
Mhh...and with this, the chapter "A/B test flags 2024" is closed. Hope for a less eventful 2025. |
# [5.8.0-dev.4](v5.8.0-dev.3...v5.8.0-dev.4) (2024-12-27) ### Bug Fixes * **GmsCore support:** Do not show battery optimization error on Android Automotive devices (Google built-in) ([#4218](#4218)) ([d6e389c](d6e389c)) ### Features * **Swipe controls:** Add option to enable/disable fullscreen swipe to next video ([#4222](#4222)) ([119092f](119092f)) * **YouTube:** Add `Exit fullscreen mode` patch ([#4223](#4223)) ([bb5d03b](bb5d03b))
# [5.8.0](v5.7.2...v5.8.0) (2024-12-30) ### Bug Fixes * **GmsCore support:** Do not show battery optimization error on Android Automotive devices (Google built-in) ([#4218](#4218)) ([d6e389c](d6e389c)) * **YouTube - Exit fullscreen mode:** Exit fullscreen mode of first video opened after cold start ([be5cf2e](be5cf2e)) * **YouTube - Force original audio:** If stream spoofing to Android then show a summary text why force audio is not available ([#4220](#4220)) ([029aee8](029aee8)) * **YouTube - Spoof video streams:** Ignore harmless error toast if hide ads is disabled ([c3423bb](c3423bb)) ### Features * **Swipe controls:** Add option to enable/disable fullscreen swipe to next video ([#4222](#4222)) ([119092f](119092f)) * **YouTube - Hide Shorts components:** Add option to hide Shorts in watch history ([#4214](#4214)) ([19c2742](19c2742)) * **YouTube - Spoof app version:** Add 'Restore old navigation and toolbar icons' ([f84e459](f84e459)) * **YouTube:** Add `Change form factor` patch ([#4217](#4217)) ([644ac5b](644ac5b)) * **YouTube:** Add `Exit fullscreen mode` patch ([#4223](#4223)) ([bb5d03b](bb5d03b)) * **YouTube:** Add in app option to select a preferred language for ReVanced specific text ([#4231](#4231)) ([3932af3](3932af3))
Will this allow us to watch next short on Open shorts in regular player enabled the same way swiping works in regular shorts player? |
@eldepor yes it can |
Allows forcing on/off the fullscreen swipe gesture.