bug(YouTube - Playback speed): Custom playback speeds, remember playback speed does not work

[LisoUseInAIKyrios]

Bug description

New playback speed menu

19.34+ has an a/b test for a new playback speed menu.

It has 0.05x increments similar to the default ReVanced custom speeds of 0.90/0.95/1.05/1.1, but can also adjust by 0.05 increments from any present.

The max speed is still limited to 2.0.

Custom playback speeds do not show in the new speed menu. Although the player overlay speed button does work correctly.

Acknowledgements

• I have checked all open and closed bug reports and this is not a duplicate.
• I have chosen an appropriate title.
• All requested information has been provided properly.

[oSumAtrIX]

I think this is fine to remove the patch. Anything above 2x is hardly useful and the precise speed slider is precise enough. On a related note, the speed entries are sent with the /player response from what I have yeen. Unless that changed, the response can be modified

[LisoUseInAIKyrios]

I find 7.0x useful to turn a video into a speed up time lapse.

Maybe the new menu is a simple feature flag and can be forced off if the old custom speed menu is desired.

Edit: The issue is fixed and custom speeds work again.

[MarcaDian]

Speed dialog button in the player call old speed menu and it works fine for me, paired with the new speed menu (although no, if you select speed in the old menu, then the selection will be ignored in the new menu), then maybe simply add a toggle to use old speed menu if it is a possible to hook flyout menu item as it is now done for the quality menu.

if i understand correctly, speed above 2x is available with premium

[LisoUseInAIKyrios]

I have premium and it's still 2.0x maximum for me.

The higher speeds only show if a default speed over 2.0x is used, and then it allows going up to 8.0x.

I assume the higher speeds might be a future premium feature.

[LisoUseInAIKyrios]

And the speed player button works correctly with the linked PR.

[oSumAtrIX]

The higher speeds only show if a default speed over 2.0x is used, and then it allows going up to 8.0x.

Default speed as in via the ReVanced patch? Then officially there's no speed higher than 2? Why would YT make it premium when it doesn't officially exist.

[LisoUseInAIKyrios]

I mean if the default ReVanced speed is set to over 2.0x, the speed menu shows as the screenshot MarcaDian posted. Allowing speeds over 2.0x might be a work in progress, and Revanced setting the current speed above 2.0x glitches the speed menu logic until it's lowered back down to 2.0 (and then it won't allow increasing above 2.0). If you get the new speed menu you'll see.

[MarcaDian]

if the default ReVanced speed is set to over 2.0x

I clarify that I do not set the default speed, I'm set speed through the speed dialog button in the player.

[LisoUseInAIKyrios]

I spent some time trying to find a feature flag for the old speed menu but could not find anything. Even with every flag I could find set to false the new menu still shows.

Spoofing to an old version fixes it and the old menu is shown, so the code is still there and works.

[oSumAtrIX]

It is possible that this isn't controlled by a feature flag, instead by the response in the player (or next) request. The response may include instructions to toggle on this UI. I have seen JS been mentioned in Litho logs too so maybe YouTube integrates it into SSR.

[LisoUseInAIKyrios]

The new speed menu is a litho component, and the old menu can be shown by slightly modifying the custom speed patch to handle the new menu litho name.

Basically fix it the same way it was fixed when the speed menu was changed from native to litho.

[someonewithpc]

Anything above 2x is hardly useful

I strongly disagree. I use anywhere between 2.5 and 3.75 regularly, depending on the video