Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube - Comments): Hide 'Comments by members' header #3308

Closed
3 tasks done
ILoveOpenSourceApplications opened this issue Jun 7, 2024 · 7 comments · Fixed by #3300 or #3317
Closed
3 tasks done

feat(YouTube - Comments): Hide 'Comments by members' header #3308

ILoveOpenSourceApplications opened this issue Jun 7, 2024 · 7 comments · Fixed by #3300 or #3317
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@ILoveOpenSourceApplications
Copy link
Contributor

Feature description

A patch which hides the 'Comments by members' header.

Screenshot_2024-06-07-11-52-05-721_app revanced android youtube~2

Motivation

YouTube already provides a comments filter by which the user can filter the members comments. Also, it'll make the comments section look more clean.

Screenshot_2024-06-07-11-51-47-873_app revanced android youtube~2

Acknowledgements

  • I have checked all open and closed feature requests and this is not a duplicate
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@ILoveOpenSourceApplications ILoveOpenSourceApplications added the Feature request Requesting a new feature that's not implemented yet label Jun 7, 2024
@ILoveOpenSourceApplications
Copy link
Contributor Author

The litho component to hide the header is sponsorships_comments_header.eml. The only issue is, as seen in the above attached screenshot, the gray separator at the bottom doesn't get hidden.

@ILoveOpenSourceApplications
Copy link
Contributor Author

ILoveOpenSourceApplications commented Jun 7, 2024

I couldn't find a separate litho for the separator only. So, the color code for that separator needs to be changed, which I don't know is possible and is just a suggestion from my end.

Edit: After a second sweep, I got the separate litho for the separator. It is sponsorships_comments_footer.eml.

@oSumAtrIX
Copy link
Member

Doesn't this only hide the header and not just the comment and thus makes it incorrectly look like it's a regular comment and not one pushed more by YouTube?

@ILoveOpenSourceApplications
Copy link
Contributor Author

I don't think so. Just because someone decided to support a channel by becoming a member doesn't make their comment irrelevant. Also, they will still have the channel badge beside their name for users to identify that they're a channel member.

@oSumAtrIX
Copy link
Member

Does YouTube push comments by members higher than other comments?

@ILoveOpenSourceApplications
Copy link
Contributor Author

ILoveOpenSourceApplications commented Jun 7, 2024

I'm not sure. In the screenshot attached channel, on his last 3-4 videos, there's atleast 1 'Comments by members' comment in the first 10 comments. But it's not consistent, as there is a chance that there could be one in the top 3 comments and then there's not. So I don't think they do push it and it works similar to that of normal comments but with an extra header (which is unnecessary).

@ILoveOpenSourceApplications
Copy link
Contributor Author

I still don't know how to link an issue to a PR. #3317 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
2 participants