Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non skip pdf in lights HittableList #1668

Open
niccolot opened this issue Jan 4, 2025 · 0 comments
Open

Non skip pdf in lights HittableList #1668

niccolot opened this issue Jan 4, 2025 · 0 comments

Comments

@niccolot
Copy link

niccolot commented Jan 4, 2025

Hello, if i add to the lights list an object that is not a metal or dielectric the image produced is like

pdfmaterial

i' ve obtained this by putting

// in the original main is glass
auto nonglass = make_shared<lambertian>(color(0.8, 0.2, 0.2));
world.add(make_shared<sphere>(point3(190,90,190), 90, nonglass));

// Light Sources
hittable_list lights;
auto m = shared_ptr<material>();
lights.add(make_shared<quad>(point3(343,554,332), vec3(-130,0,0), vec3(0,0,-105), m));
lights.add(make_shared<sphere>(point3(190, 90, 190), 90, m));

in the main.cpp of therestofyourlife part.

I may not have understood correctly this part of the code and thus it may not be an actual issue but still i wanted to ask this since also a material like a lambertian is still emitting some reflected light

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant