-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New version for Laravel 10 #47
Comments
Hi, we're on an older version of laravel and don't have a plan to update it (laravel). That's why I did not do a v10 release. I figured that if anybody needs it, they'll probably write an issue. And you have :) If you're fluent in php you can try it yourself and do a PR? If not, I could maybe do it during this week sometime. |
Hi RatKo:
I think I don't master PHP enough to make a PR. It would be great if you could update the driver versión.
Best Regards:
…____
José Antonio Osuna Zamorano
Área de I+D+i
***@***.***
T: + 34 957 429 060 (1402)
***@***.******@***.***>
magtel.es<http://www.magtel.es/>
P.E. Las Quemadas
c/ Imprenta de la Alborada 114
14014 - Córdoba
La información transmitida está destinada solo a la persona o entidad a la que está dirigida y puede contener material confidencial y/o privilegiado. Se prohíbe cualquier revisión, retransmisión, difusión u otro uso, o la adopción de cualquier acción basada en esta información, por parte de personas o entidades distintas del destinatario previsto. Si ha recibido esto por error, comuníquese con el remitente y elimine el material de cualquier ordenador.
En aras del cumplimiento del Reglamento (UE) 2016/679 del Parlamento Europeo y del Consejo, de 27 de abril de 2016 y de la Ley Orgánica 3/2018, de 5 de diciembre, de Protección de Datos Personales y garantía de los derechos digitales (LOPD-GDD), puede ejercer los derechos de acceso, rectificación, cancelación, limitación, oposición y portabilidad mediante correo electrónico a: ***@***.******@***.***>. Para información adicional sobre la política de privacidad puede consultarlo en la siguiente dirección www.magtel.es/proteccion-de-datos/<https://www.magtel.es/proteccion-de-datos/>
De: RatkoR ***@***.***>
Enviado el: martes, 17 de octubre de 2023 10:50
Para: RatkoR/laravel-crate.io ***@***.***>
CC: José Antonio Osuna Zamorano ***@***.***>; Author ***@***.***>
Asunto: Re: [RatkoR/laravel-crate.io] New version for Laravel 10 (Issue #47)
No suele recibir correos electrónicos de ***@***.******@***.***>. Por qué esto es importante<https://aka.ms/LearnAboutSenderIdentification>
Hi,
we're on an older version of laravel and don't have a plan to update it (laravel). That's why I did not do a v10 release. I figured that if anybody needs it, they'll probably write an issue. And you have :)
If you're fluent in php you can try it yourself and do a PR? If not, I could maybe do it during this week sometime.
—
Reply to this email directly, view it on GitHub<#47 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMYH4TKRZDMKG2O5XA2Q24DX7ZBDVAVCNFSM6AAAAAA6DOQSM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRVHE3DGMRYHA>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
I created a PR #48. As I said we did not migrate to laravel 10 and cannot test this PR as much as I would want to. I run did run tests that are in this repo and I also run some other tests that we have. Just that I did not run full range tests that we also have as they are not laravel 10 ready. So... any chance you could try with branch "laravel_10" and see if it works for you also? |
Hi Ratko:
I have installed the version of the driver with composer as follows:
composer require ratkor/laravel-crate.io:dev-laravel_10
I just tested this versión and it works well for Laravel 10. I have only tried making queries, but the result is good.
Best regards:
____
José Antonio Osuna Zamorano
Área de I+D+i
***@***.***
T: + 34 957 429 060 (1402)
***@***.******@***.***>
magtel.es<http://www.magtel.es/>
P.E. Las Quemadas
c/ Imprenta de la Alborada 114
14014 - Córdoba
La información transmitida está destinada solo a la persona o entidad a la que está dirigida y puede contener material confidencial y/o privilegiado. Se prohíbe cualquier revisión, retransmisión, difusión u otro uso, o la adopción de cualquier acción basada en esta información, por parte de personas o entidades distintas del destinatario previsto. Si ha recibido esto por error, comuníquese con el remitente y elimine el material de cualquier ordenador.
En aras del cumplimiento del Reglamento (UE) 2016/679 del Parlamento Europeo y del Consejo, de 27 de abril de 2016 y de la Ley Orgánica 3/2018, de 5 de diciembre, de Protección de Datos Personales y garantía de los derechos digitales (LOPD-GDD), puede ejercer los derechos de acceso, rectificación, cancelación, limitación, oposición y portabilidad mediante correo electrónico a: ***@***.******@***.***>. Para información adicional sobre la política de privacidad puede consultarlo en la siguiente dirección www.magtel.es/proteccion-de-datos/<https://www.magtel.es/proteccion-de-datos/>
De: RatkoR ***@***.***>
Enviado el: miércoles, 18 de octubre de 2023 13:37
Para: RatkoR/laravel-crate.io ***@***.***>
CC: José Antonio Osuna Zamorano ***@***.***>; Author ***@***.***>
Asunto: Re: [RatkoR/laravel-crate.io] New version for Laravel 10 (Issue #47)
No suele recibir correos electrónicos de ***@***.******@***.***>. Por qué esto es importante<https://aka.ms/LearnAboutSenderIdentification>
I created a PR #48<#48>.
As I said we did not migrate to laravel 10 and cannot test this PR as much as I would want to. I run did run tests that are in this repo and I also run some other tests that we have. Just that I did not run full range tests that we also have as they are not laravel 10 ready.
So... any chance you could try with branch "laravel_10" and see if it works for you also?
—
Reply to this email directly, view it on GitHub<#47 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMYH4TOVZCG4NNZT2M2NAKLX765OFAVCNFSM6AAAAAA6DOQSM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRYGI3DIMBVHA>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
Great! I'll release a new version today. Thanks |
I think this issue is not completed. As Laravel 10 requires DBAL 3.0 but crate-dbal doesn't yet support this version. |
I am currently working with Laravel 10. Is a new version of the driver planned for this version of Laravel?
The text was updated successfully, but these errors were encountered: