Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version for Laravel 10 #47

Closed
oszajo opened this issue Oct 17, 2023 · 6 comments
Closed

New version for Laravel 10 #47

oszajo opened this issue Oct 17, 2023 · 6 comments

Comments

@oszajo
Copy link

oszajo commented Oct 17, 2023

I am currently working with Laravel 10. Is a new version of the driver planned for this version of Laravel?

@RatkoR
Copy link
Owner

RatkoR commented Oct 17, 2023

Hi,

we're on an older version of laravel and don't have a plan to update it (laravel). That's why I did not do a v10 release. I figured that if anybody needs it, they'll probably write an issue. And you have :)

If you're fluent in php you can try it yourself and do a PR? If not, I could maybe do it during this week sometime.

@oszajo
Copy link
Author

oszajo commented Oct 17, 2023 via email

@RatkoR
Copy link
Owner

RatkoR commented Oct 18, 2023

I created a PR #48.

As I said we did not migrate to laravel 10 and cannot test this PR as much as I would want to. I run did run tests that are in this repo and I also run some other tests that we have. Just that I did not run full range tests that we also have as they are not laravel 10 ready.

So... any chance you could try with branch "laravel_10" and see if it works for you also?

@oszajo
Copy link
Author

oszajo commented Oct 23, 2023 via email

@RatkoR
Copy link
Owner

RatkoR commented Oct 23, 2023

Great!

I'll release a new version today.

Thanks

@RatkoR RatkoR closed this as completed Oct 23, 2023
@JulianMar
Copy link
Contributor

I think this issue is not completed. As Laravel 10 requires DBAL 3.0 but crate-dbal doesn't yet support this version.
There is already an issue in the repo crate/crate-dbal#106 but no activity yet.
I will try to get some work into this after the holidays. Just wanted to let you guys know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants