Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSID password stored in clear text in ratos-wpa-supplicant.txt #152

Closed
smwoodward-alpha opened this issue Jul 20, 2024 · 4 comments
Closed
Labels
enhancement New feature or request

Comments

@smwoodward-alpha
Copy link

What happened

In ratos-wpa-supplicant.txt, the password is commented out but is in clear text in addition to the hashed password

What did you expect to happen

the wireless password shouldn't be in clear text. The #psk="xxxxx" line should be removed.

How to reproduce

Looked in ratos-wpa-supplicant.txt and the following lines are there.
ssid="MyWifi"
#psk="printers1234"
psk=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
scan_freq=5200

Additional information

No response

@smwoodward-alpha smwoodward-alpha added the bug Something isn't working label Jul 20, 2024
@funtimeerror
Copy link

dupe of #142 ?

@miklschmidt
Copy link
Member

@funtimeerror he's a spammer with a personal vendetta, he created 10 duplicates of this issue

This isn't a bug, it's the direct output of wpa_passphrase. Most other pi distributions only use cleartext. However, removing it from the block would be an enhancement, but it has very low priority right now, and it would reduce debuggability. There is still an issue where some special characters don't work correctly. Furthermore, if someone gains access to your pi you have much bigger issues than sharing your wifi password with the intruder. Don't expose your printer to the internet, if you have to, use VPN.

@miklschmidt miklschmidt added enhancement New feature or request and removed bug Something isn't working labels Aug 28, 2024
@funtimeerror
Copy link

@miklschmidt should be solvable via regex... i'll take a stab at it in the next week or two

@funtimeerror
Copy link

PR Rat-OS/RatOS-configurator/pull/20 submitted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants