Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constant ASC is used one level lower than defined #15

Open
szepeviktor opened this issue Oct 28, 2020 · 3 comments
Open

Constant ASC is used one level lower than defined #15

szepeviktor opened this issue Oct 28, 2020 · 3 comments

Comments

@szepeviktor
Copy link
Contributor

szepeviktor commented Oct 28, 2020 •
edited
Loading

Used in Contracts\QueryBuilder interface,
defined in QueryBuilder

How could that be fixed?
@joelambert
Copy link
Member

@szepeviktor good spot, any suggestions?

@szepeviktor
Copy link
Contributor Author

@joelambert I don't dare to say software design in a GitHub issue. Sorry.

@szepeviktor
Copy link
Contributor Author

I may do more harm than good. Maybe an interface should not have default values for parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joelambert @szepeviktor