Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Add missing Env concept #1715

Open
7 tasks
Tracked by #1717
nirs opened this issue Dec 11, 2024 · 0 comments
Open
7 tasks
Tracked by #1717

e2e: Add missing Env concept #1715

nirs opened this issue Dec 11, 2024 · 0 comments
Labels
test Testing related issue

Comments

@nirs
Copy link
Member

nirs commented Dec 11, 2024

We are missing the important concept of environment in the e2e framework.

Tests are composed of workload, deployer, repository and environment. We have workloads and deployers, and we read repository details and clusters from the config.

The clusters are kept now in util.Context - we need to rename it and make it available via the test context.

Tasks:

  • Move util/config.go to test/config.go
  • Move util.context to test/env.go, rename Context to Env
  • Add GetEnv to config
  • Add Env() to types.Context
  • Access cluster client via Context (e.g. ctx.Env().Hub.Client)
  • Add Cluster.Name to tests can use the right cluster names instead of fake name ("c1")
    • Initialize from config or fetch from managedcluster resource
  • Add Env.Name and log the name of the environment tested
@nirs nirs added the test Testing related issue label Dec 11, 2024
@nirs nirs mentioned this issue Dec 11, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Testing related issue
Projects
None yet
Development

No branches or pull requests

1 participant