Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the test helper constant NoS3StoreAvailable #1710

Open
raghavendra-talur opened this issue Dec 9, 2024 · 3 comments
Open

Remove the test helper constant NoS3StoreAvailable #1710

raghavendra-talur opened this issue Dec 9, 2024 · 3 comments
Labels
good first issue Good for newcomers

Comments

@raghavendra-talur
Copy link
Member

In file internal/controller/ramenconfig.go

// FIXME
const NoS3StoreAvailable = "NoS3"

@raghavendra-talur raghavendra-talur added the good first issue Good for newcomers label Dec 9, 2024
@Ankush1oo8
Copy link

Ankush1oo8 commented Dec 9, 2024

@raghavendra-talur Just to remove it

@raghavendra-talur
Copy link
Member Author

@raghavendra-talur Just to remove it

@Ankush1oo8 No, the constant is being used in multiple places in the code and those parts need to be refactored before this line is deleted. Needs understanding of basic ramen workflow to make the changes.

@sureshkrishnan-v
Copy link

Hi, I’d like to work on this issue as a first-time contributor—could you confirm if it’s available and share any guidelines?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants