Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize Icon, Favicon and the Logo #13

Open
Rajan opened this issue May 11, 2018 · 8 comments
Open

Customize Icon, Favicon and the Logo #13

Rajan opened this issue May 11, 2018 · 8 comments

Comments

@Rajan
Copy link
Owner

Rajan commented May 11, 2018

Everything should be customizable via profile and settings menus.
People should be able to change the logo, square icon and favicon.

@Rajan Rajan added the todo label May 11, 2018
@Rajan
Copy link
Owner Author

Rajan commented May 11, 2018

We should have a prefs table with following fields:

  • doBlog (turn on/off blog menu)
  • logoHoriz
  • logoSquare
  • favicon
  • tagline
  • menuList (?)

@Rajan
Copy link
Owner Author

Rajan commented May 11, 2018

Should we have a separate prefs table or should we club it with the menus table?
Keeping it separate will help us with the CRUD operations and make it easy to map to firebase and others.

Clubbing it together will reduce the HTTP requests because we won't need to make a call for prefs and make another call for menus.

Thoughts?

@madguy02
Copy link
Collaborator

I think clubbing it together should be good for now. Considering firebase in the loop, how difficult will the mapping be in this case? @Rajan

@s-kris
Copy link
Collaborator

s-kris commented May 11, 2018

I think prefs should go into a separate table - it's less mixed up that way.

@Rajan
Copy link
Owner Author

Rajan commented May 11, 2018

We can keep the tables and models separate and keep the API calls clubbed into a single request.

@s-kris
Copy link
Collaborator

s-kris commented May 11, 2018

Cool

@sujaykundu777
Copy link
Collaborator

Yeah that will be really useful 😀

@Rajan
Copy link
Owner Author

Rajan commented Jun 22, 2018

@s-kris I've added Firebase stubs for uploading logos and retrieving logos with 55943ba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants