Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ShowMessageBoxRequest #25

Open
nazarenomanco opened this issue Mar 7, 2016 · 7 comments
Open

Add ShowMessageBoxRequest #25

nazarenomanco opened this issue Mar 7, 2016 · 7 comments

Comments

@nazarenomanco
Copy link
Member

@mauroservienti What about adding a ShowMessageBoxRequest to allow the user show the Windows Message Box?

Something like:

class ShowMessageBoxRequest 
{
    public string Message { get; set; }
    public string Caption { get; set; }
    public MessageBoxImage Icon { get; set; }
}

If needed I have the working code.

@mauroservienti
Copy link
Member

IMO this should not happen, the WPF MessageBox class has several options that the above sample does not take into account, the only option to deign it right is to leak the MessageBox class into the Radical code and worse to leak the MessageBox class into the ViewModel code, this should not happen. Given all the options the MessageBox has wrapping it in our own thing is not an option as well.

@micdenny thoughts?

@micdenny
Copy link
Member

micdenny commented Mar 8, 2016

For my personal point of view, I've stopped using messagebox because it sticks on a system component, and because it does not look and feel like a custom view. We usually have a custom modal view that over all the canvas using a Grid in a MainView, and yes we use messaging to open/close and interact with the modal view. I would not add this in radical.

@mauroservienti
Copy link
Member

What about introducing a custom message box thing that utilizes UI Composition to achieve a better result?

@mauroservienti
Copy link
Member

Similar to what the Splash Screen feature does

@micdenny
Copy link
Member

micdenny commented Mar 8, 2016

that could be interesting, injecting in a MainView or generally on a Grid if requested with some kind of attached property

@mauroservienti
Copy link
Member

@nazarenomanco
Copy link
Member Author

That's really better... I have asked because in my program I have to interact with the user.
Your solution is for sure better than mine and allows the management of a Response that in my actual implementation is not possible to manage.

I'll study the splash sceen implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants