Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce pre-commit hook and formatter #341

Open
2 of 5 tasks
djs0109 opened this issue Oct 29, 2024 · 1 comment · May be fixed by #354
Open
2 of 5 tasks

Introduce pre-commit hook and formatter #341

djs0109 opened this issue Oct 29, 2024 · 1 comment · May be fixed by #354
Assignees
Labels
feature request Request a potential feature

Comments

@djs0109
Copy link
Contributor

djs0109 commented Oct 29, 2024

In order to simplify the review process, we should introduce the pre-commit hook with a formatter.

requirements:

  • pep 8 conform
  • identical code length control
  • what else?

todos:

  • test the formatter locally
  • run formatter once for the current master branch, and check the results
  • create pre-commit hook
  • update setup.py
  • update readme
@djs0109 djs0109 added the feature request Request a potential feature label Oct 29, 2024
Copy link

Branch 341-Introduce-pre-commit-hook-and-formatter created!

@sbanoeon sbanoeon linked a pull request Nov 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request a potential feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants