Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "AOI" to "incAng" for naming convention #1524

Open
TobiasSpratte opened this issue Jul 26, 2024 · 3 comments
Open

Change "AOI" to "incAng" for naming convention #1524

TobiasSpratte opened this issue Jul 26, 2024 · 3 comments
Assignees

Comments

@TobiasSpratte
Copy link
Contributor

TobiasSpratte commented Jul 26, 2024

In the ThermalZones.HighOrder models and in some other models like AixLib.Utilities.Sources.PrescribedSolarRad, "AOI" is used as the name for the incidence angle. In the IBPSA models, "inc" or "incAng" is used. I suggest to also use "incAng" instead of "AOI".

@Yugalgarg2002
Copy link

I am willing to take up this issue, please assign it to me.

@TobiasSpratte TobiasSpratte changed the title Change "AOI" to "inc" for naming convention Change "AOI" to "incAng" for naming convention Jul 29, 2024
@TobiasSpratte
Copy link
Contributor Author

Thank you for your support! After a discussion on this topic, the name "incAng" would be more appropriate. Would you also make this change?

@Yugalgarg2002
Copy link

Sure, I will take it up, assign it to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants