Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drug_regulatory_status_world_wide is not a valid predicate #402

Open
amykglen opened this issue Jul 18, 2024 · 3 comments
Open

drug_regulatory_status_world_wide is not a valid predicate #402

amykglen opened this issue Jul 18, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@amykglen
Copy link
Member

so the Plover build for KG2.10.0c is spitting out the warning WARNING: Provided predicate(s) {'biolink:drug_regulatory_status_world_wide'} do not exist in Biolink 4.2.0

looking into that, I can see in KG2.10.0pre that some edges have the predicate drug_regulatory_status_world_wide, like this one:
Screenshot 2024-07-18 at 9 11 18 AM

but that doesn't quite appear to be a predicate in Biolink... I can see that term listed in the Biolink model 4.2.0 yaml file (here) but it doesn't have an is_a slot, which means it doesn't fall within the predicate tree: https://tree-viz-biolink.herokuapp.com/predicates/4.2.0 (nor does it appear to be a mixin)

do you know if this is really meant to be used as a predicate? or is it supposed to be the name of a node property?

or maybe these edges are all from RepoDB anyway, which we're going to be removing from KG2?

it looks like they're mostly from RepoDB, but a few hundred from NCIT as well:

match p=(n)-[e:`biolink:drug_regulatory_status_world_wide`]->(m) return distinct e.primary_knowledge_source, count(distinct e) order by count(distinct e)
e.primary_knowledge_source count(distinct e)
"infores:ncit" 402
"infores:repodb" 9312

(FYI this shouldn't be a blocker or anything for rolling out KG2.10.0c)

@ecwood
Copy link
Collaborator

ecwood commented Jul 18, 2024

It is in Biolink, and it is mapped to our RepoDB mappings in there:
image

I suspect that there was confusion when creating the mappings (which was done earlier this year). The predicate doesn't really make sense either (it seems more like a property than a predicate, and it doesn't describe the relationship depicted in those edges). Since RepoDB is getting taken out, I'm not overly concerned, but I will check out NCIT to see why this is happening there.

@amykglen
Copy link
Member Author

just to clarify - I agree it's in Biolink, but it's not in Biolink as a descendant of the related_to predicate, which all other predicates I know of are. so that's why I'm not sure if it's considered a valid predicate..

@amykglen
Copy link
Member Author

amykglen commented Sep 4, 2024

at today's AHM, we noticed that this is causing TRAPI validation errors for ARAX:

{
  "critical": {},
  "error": {
    "error.knowledge_graph.edge.predicate.invalid": {
      "infores:repodb -> infores:rtx-kg2 -> infores:arax": {
        "biolink:drug_regulatory_status_world_wide": [
          {
            "edge_id": "CHEBI:86463[biolink:Drug|biolink:MolecularMixture]--biolink:drug_regulatory_status_world_wide->MONDO:0007186[biolink:DiseaseOrPhenotypicFeature|biolink:PhenotypicFeature|biolink:Disease]"
          }
        ]
      }
    }
  },

https://arax.ncats.io/?r=e4274554-09e0-4188-a325-376b2ae295ee

@amykglen amykglen added the bug Something isn't working label Sep 4, 2024
@amykglen amykglen changed the title Is drug_regulatory_status_world_wide a valid predicate? drug_regulatory_status_world_wide is not a valid predicate Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants