-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start naming KG2 TSV tarball with version number (in S3)? #140
Comments
OK, I am thinking about how to do this while still preserving automation in the |
I have created branch issue-140 for working this issue |
I have a mini build-system for the |
Lili and I discussed it and we feel this issue may slip until after 2.7.4 |
I'm specifically thinking that the output filenames that go to the S3 bucket should have the version number in the filename. I don't think the filenames on In hindsight, I don't think my decision to copy files like |
I can try to work on this in the next few weeks. I like the idea of a version-named folder on S3 to avoid clutter. |
is there any way this could be implemented soon? really all we would like is that the |
This should be done now. It will look something like |
awesome, thank you!! |
This was successful in the KG2.10.1pre build, other than the report compare (as described here: #408 (comment)), so I am closing out this issue. |
Thank you @ecwood for doing this! |
Instead of extracting KG2pre data via Neo4j, going forward the KG2c build process is going to ingest
kg2-tsv-for-neo4j.tar.gz
(downloaded from thertx-kg2
S3 bucket).Wondering if it would be reasonable to start naming that tarball in S3 with the KG2 version number? So, something like:
kg2-7-2-tsv-for-neo4j.tar.gz
I realize that means we'd have to periodically delete old versions of the file so the S3 bucket doesn't get overly full, but it'd be really nice for the KG2c build process to be able to make sure it gets the right tarball (since currently the tarball is overwritten every time a new KG2pre build is done).
The text was updated successfully, but these errors were encountered: