Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

366 bug in loading logic #373

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

366 bug in loading logic #373

wants to merge 2 commits into from

Conversation

samlamont
Copy link
Collaborator

Removes cache directory before converting files during loading for:

  • location attributes
  • locations
  • location crosswalk
  • primary timeseries
  • secondary timeseries

@samlamont samlamont linked an issue Jan 16, 2025 that may be closed by this pull request
Bug in loading logic #366
Open
@samlamont
Copy link
Collaborator Author

I just realized we have the clean_cache() method on the Evaluation class, I think I should have probably used that instead of creating the new function (remove_dir_if_exists()). I will take another look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgdenno mgdenno Awaiting requested review from mgdenno

@samland1116 samland1116 Awaiting requested review from samland1116

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in loading logic
1 participant
@samlamont