Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signature metrics #266

Open
mgdenno opened this issue Sep 27, 2024 · 2 comments
Open

Add signature metrics #266

mgdenno opened this issue Sep 27, 2024 · 2 comments

Comments

@mgdenno
Copy link
Contributor

mgdenno commented Sep 27, 2024

Under this issue, we want to:

  • Split out signatures from our current metrics (i.e., the "metrics" that only take one timeseries, mean, min, max, etc.)
  • Create a new class of metrics that first calculates the signature for primary and secondary (based on some initial grouping, event, annual, etc), and then calculates a metric on top of that. A two-step process.
  • The returned "metric" could be just the final metric or a dictionary that contains the signatures (A series of signatures) and the signature metric.

There is still something missing in this concept I think. We can currently do this with chained queries I think.

@mgdenno
Copy link
Contributor Author

mgdenno commented Sep 27, 2024

This needs some examples identified from the metrics spreadsheet.

@mgdenno
Copy link
Contributor Author

mgdenno commented Jan 3, 2025

Not sure if this is mentioned elsewhere, but we should also consider changing the different metric properties to have more explicit names i.e., input_timeseries for signature metrics and primary_input_timeseries and secondary_input_timeseries for comparative metrics because the current pattern is difficult for convey to users. We don't convey that the first value is the primary and the second the secondary, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant