-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add M3U format #3998
base: master
Are you sure you want to change the base?
Add M3U format #3998
Conversation
pls put all code inside a single class |
can I ask you what's the rationale for this? While I can see how moving But I'm not particularly good at PHP, so maybe you have suggestions for how to keep the code well encapsulated, while having the same benefit of "all code in a single class". |
those are a bit silly, but let's be coherent with other tests
php does not have modules like python does. your previous function also it's my subjective preference to have code closer together and not spread out. i'd prefer you drop |
like this? 266a6c0 if you think this is still not right, just tell me: I'm eager to learn :) |
gentle ping :) |
yes still thinking about this. |
fixes #3995
this is especially useful for podcasts.