From e37ada765b04fd770510afac68c22b32ed5ddbd8 Mon Sep 17 00:00:00 2001 From: Ingvar Stepanyan Date: Mon, 26 Aug 2024 17:10:35 +0100 Subject: [PATCH] Remove obsolete #[allow] --- src/api/autogen/index.ts | 1 - src/api/image_array/mod.rs | 2 -- src/api/mod.rs | 11 ----------- src/response.rs | 1 - 4 files changed, 15 deletions(-) diff --git a/src/api/autogen/index.ts b/src/api/autogen/index.ts index eecd6f8..4ea390a 100644 --- a/src/api/autogen/index.ts +++ b/src/api/autogen/index.ts @@ -731,7 +731,6 @@ ${stringifyIter(types, ({ features, type }) => { ${cfg} #[derive(Debug, PartialEq, Eq, Clone, Copy, Serialize_repr, Deserialize_repr, TryFromPrimitive, IntoPrimitive)] #[repr(${type.baseType})] - #[allow(clippy::default_numeric_fallback)] // false positive https://github.com/rust-lang/rust-clippy/issues/9656 #[allow(missing_docs)] // some enum variants might not have docs and that's okay pub enum ${type.name} { ${stringifyIter( diff --git a/src/api/image_array/mod.rs b/src/api/image_array/mod.rs index 651f2bf..e97634b 100644 --- a/src/api/image_array/mod.rs +++ b/src/api/image_array/mod.rs @@ -29,7 +29,6 @@ type ArcArray3 = ndarray::ArcArray; IntoPrimitive, )] #[repr(i32)] -#[allow(clippy::default_numeric_fallback)] // false positive https://github.com/rust-lang/rust-clippy/issues/9656 pub enum ImageArrayRank { /// 2D Rank2 = 2_i32, @@ -39,7 +38,6 @@ pub enum ImageArrayRank { #[derive(Debug, PartialEq, Eq, Clone, Copy, IntoPrimitive, TryFromPrimitive)] #[repr(i32)] -#[allow(clippy::default_numeric_fallback)] // false positive https://github.com/rust-lang/rust-clippy/issues/9656 pub(crate) enum TransmissionElementType { I16 = 1, I32 = 2, diff --git a/src/api/mod.rs b/src/api/mod.rs index f5db3d3..bc533c4 100644 --- a/src/api/mod.rs +++ b/src/api/mod.rs @@ -78,7 +78,6 @@ pub use image_array::*; IntoPrimitive, )] #[repr(i32)] -#[allow(clippy::default_numeric_fallback)] // false positive https://github.com/rust-lang/rust-clippy/issues/9656 #[allow(missing_docs)] // some enum variants might not have docs and that's okay pub enum CameraState { /// At idle state, available to start exposure. @@ -176,7 +175,6 @@ impl LastExposureStartTime { IntoPrimitive, )] #[repr(i32)] -#[allow(clippy::default_numeric_fallback)] // false positive https://github.com/rust-lang/rust-clippy/issues/9656 #[allow(missing_docs)] // some enum variants might not have docs and that's okay pub enum SensorType { /// Single-plane monochrome sensor. @@ -212,7 +210,6 @@ pub enum SensorType { IntoPrimitive, )] #[repr(i32)] -#[allow(clippy::default_numeric_fallback)] // false positive https://github.com/rust-lang/rust-clippy/issues/9656 #[allow(missing_docs)] // some enum variants might not have docs and that's okay pub enum GuideDirection { North = 0, @@ -238,7 +235,6 @@ pub enum GuideDirection { IntoPrimitive, )] #[repr(i32)] -#[allow(clippy::default_numeric_fallback)] // false positive https://github.com/rust-lang/rust-clippy/issues/9656 #[allow(missing_docs)] // some enum variants might not have docs and that's okay pub enum CalibratorStatus { /// This device does not have a calibration capability. @@ -274,7 +270,6 @@ pub enum CalibratorStatus { IntoPrimitive, )] #[repr(i32)] -#[allow(clippy::default_numeric_fallback)] // false positive https://github.com/rust-lang/rust-clippy/issues/9656 #[allow(missing_docs)] // some enum variants might not have docs and that's okay pub enum CoverStatus { /// This device does not have a cover that can be closed independently. @@ -310,7 +305,6 @@ pub enum CoverStatus { IntoPrimitive, )] #[repr(i32)] -#[allow(clippy::default_numeric_fallback)] // false positive https://github.com/rust-lang/rust-clippy/issues/9656 #[allow(missing_docs)] // some enum variants might not have docs and that's okay pub enum ShutterState { /// The shutter or roof is open. @@ -343,7 +337,6 @@ pub enum ShutterState { IntoPrimitive, )] #[repr(i32)] -#[allow(clippy::default_numeric_fallback)] // false positive https://github.com/rust-lang/rust-clippy/issues/9656 #[allow(missing_docs)] // some enum variants might not have docs and that's okay pub enum AlignmentMode { /// Altitude-Azimuth type mount. @@ -370,7 +363,6 @@ pub enum AlignmentMode { IntoPrimitive, )] #[repr(i32)] -#[allow(clippy::default_numeric_fallback)] // false positive https://github.com/rust-lang/rust-clippy/issues/9656 #[allow(missing_docs)] // some enum variants might not have docs and that's okay pub enum EquatorialCoordinateType { /// Custom or unknown equinox and/or reference frame. @@ -403,7 +395,6 @@ pub enum EquatorialCoordinateType { IntoPrimitive, )] #[repr(i32)] -#[allow(clippy::default_numeric_fallback)] // false positive https://github.com/rust-lang/rust-clippy/issues/9656 #[allow(missing_docs)] // some enum variants might not have docs and that's okay pub enum PierSide { /// Normal pointing state - Mount on the East side of pier (looking West). @@ -430,7 +421,6 @@ pub enum PierSide { IntoPrimitive, )] #[repr(i32)] -#[allow(clippy::default_numeric_fallback)] // false positive https://github.com/rust-lang/rust-clippy/issues/9656 #[allow(missing_docs)] // some enum variants might not have docs and that's okay pub enum DriveRate { /// Sidereal tracking rate (15.041 arcseconds per second). @@ -522,7 +512,6 @@ impl TelescopeUtcdate { IntoPrimitive, )] #[repr(i32)] -#[allow(clippy::default_numeric_fallback)] // false positive https://github.com/rust-lang/rust-clippy/issues/9656 #[allow(missing_docs)] // some enum variants might not have docs and that's okay pub enum TelescopeAxis { Primary = 0, diff --git a/src/response.rs b/src/response.rs index 9f58487..f655a91 100644 --- a/src/response.rs +++ b/src/response.rs @@ -15,7 +15,6 @@ impl From for ValueResponse { #[cfg(feature = "client")] impl ValueResponse { - #[allow(clippy::missing_const_for_fn)] // https://github.com/rust-lang/rust-clippy/issues/9271 pub(crate) fn into(self) -> T { self.value }