Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: error: operand #0 does not dominate this use #564

Open
xinyazhang opened this issue Apr 22, 2024 · 2 comments
Open

[Issue]: error: operand #0 does not dominate this use #564

xinyazhang opened this issue Apr 22, 2024 · 2 comments

Comments

@xinyazhang
Copy link

Problem Description

Regression found in a09c6b3
Cannot reproduce in 45d8732 (a09c6b3~1)

Operating System

Ubuntu 20.04.6 LTS

CPU

AMD EPYC 7542

GPU

AMD Instinct MI210

ROCm Version

ROCm 6.0.0

ROCm Component

No response

Steps to Reproduce

git clone https://github.com/ROCm/aotriton.git
cd aotriton
pytest -s tritonsrc/test_backward.py -v -k 'test_op_bwd[False-1.2-dtype2-0.0-False-587-4-16-4-4]'

Docker Image: rocm/pytorch-private:compute-rocm-rel-6.1-82_ubuntu20.04_py3.9_pytorch_rocm6.1_internal_testing_70d92c0

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

No response

@xinyazhang
Copy link
Author

Hit the following error when running the UTs shown above.

loc("/home/xinyazha/aotriton/tritonsrc/fwd_kernel.py":262:24): error: operand #0 does not dominate this use                                                                                                                                   
python: /home/xinyazha/triton/lib/Dialect/TritonGPU/Transforms/AMDReorderInstructions.cpp:130: void TritonAMDGPUReorderInstructionsPass::moveImmediatelyAfterOperands(mlir::Operation*, llvm::SmallVector<mlir::Operation*>&): Assertion `succ
eeded(mlir::verify(m))' failed.                                                                                        
Fatal Python error: Aborted 

@xinyazhang xinyazhang changed the title [Issue]: error: operand #0 does not dominate this use [Issue]: error: operand #0 does not dominate this use Apr 24, 2024
@jerryyin
Copy link
Member

jerryyin commented Jun 5, 2024

@oplavsic Have we already fixed this?

@xinyazhang Does this still exist in the latest triton upstream?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants